New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609312 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

Crash in OmniboxPopupViewMacTest.UpdatePopupAppearance under Material Design

Project Member Reported by shrike@chromium.org, May 4 2016 
The issue is there's a DCHECK of the proposed Omnibox table width in OmniboxPopupViewMac::PositionPopup, and in the test harness the table width calculation returns 0. In MD the table is the width of the window, so fix by getting the width directly from the omnibox textfield's window.
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d60d2a2181c8d3a635eb17d784dfd3402b8c8c92

commit d60d2a2181c8d3a635eb17d784dfd3402b8c8c92
Author: shrike <shrike@chromium.org>
Date: Thu May 05 18:57:44 2016

[Mac][Material Design] Get Omnibox table width from dropdown window.

Under Material Design the suggestion table is the width of the
Omnibox window. OmniboxPopupViewMac::PositionPopup() took this width
from -[BrowserWindowController omniboxPopupAnchorRect], which
returns the empty rect in the unit test test harness. This resulted
in a zero-width table that tripped a DCHECK when called from
OmniboxPopupViewMacTest.UpdatePopupAppearance.

With this change the Omnibox grabs the window width direclty from the
Omnibox textfield's window, which is available under normal usage
and in the test harness.

R=avi@chromium.org
BUG= 609312 

Review-Url: https://codereview.chromium.org/1951143002
Cr-Commit-Position: refs/heads/master@{#391860}

[modify] https://crrev.com/d60d2a2181c8d3a635eb17d784dfd3402b8c8c92/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

Comment 2 by shrike@chromium.org, May 5 2016

Status: Fixed (was: Started)
►

Sign in to add a comment