"git cl issue 0" doesn't reset gerrit issue |
||
Issue descriptionWhat steps will reproduce the problem? 1. git clone clank 2. git new-branch foo 3. make a change 4. git commit -a -m "Some message" 5. git cl upload --squash --force -t "Some title" 6. git cl issue 0 7. git cl upload --squash --force -t "Some title" What is the expected result? A second, wholly new CL should be uploaded. What happens instead of that? A new patchset is added to the original CL. When I run "git cl issue 0", I am explicitly choosing to disassociate my current branch from the review which already exists. Git-cl (or gerrit) shouldn't recreate that association just because it is convenient or the change-ids match up. New change ids should be generated instead.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/9b7fd71c48002d0dbc763bfa12ba0deaa7b7ab0c commit 9b7fd71c48002d0dbc763bfa12ba0deaa7b7ab0c Author: tandrii@chromium.org <tandrii@chromium.org> Date: Wed Jun 01 13:45:20 2016 git cl issue 0 should really clear issue. It used to clear just issue number and patchset, but that's not all state that associates a given branch with codereview site. R=andybons@chromium.org BUG= 609295 Review-Url: https://codereview.chromium.org/2032433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300683 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/9b7fd71c48002d0dbc763bfa12ba0deaa7b7ab0c/git_cl.py [modify] https://crrev.com/9b7fd71c48002d0dbc763bfa12ba0deaa7b7ab0c/tests/git_cl_test.py
,
Jun 1 2016
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/e9c7c0e86981f777049ed74835b3853e3498e257 commit e9c7c0e86981f777049ed74835b3853e3498e257 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jun 01 13:56:08 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/9b7fd71c48002d0dbc763bfa12ba0deaa7b7ab0c git cl issue 0 should really clear issue. (tandrii@chromium.org) R=andybons@chromium.org,tandrii@chromium.org BUG= 609295 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2026893003 [modify] https://crrev.com/e9c7c0e86981f777049ed74835b3853e3498e257/infra/config/recipes.cfg
,
Jun 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/6e8dfbba728bdadca404e0122153cbede2755965 commit 6e8dfbba728bdadca404e0122153cbede2755965 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jun 01 13:58:47 2016 |
||
►
Sign in to add a comment |
||
Comment 1 by tandrii@chromium.org
, Jun 1 2016