New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609256 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 592052
issue 594034
issue 599172
issue 599173
issue 609181
issue 609190
issue 609196
issue 609199
issue 609201
issue 609206
issue 609400
issue 609401
issue 609403



Sign in to add a comment

HWTest failures on peach_pit-tot-chrome-pfq-informational

Project Member Reported by afakhry@chromium.org, May 4 2016

Issue description

https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/peach_pit-tot-chrome-pfq-informational/builds/1285

These failures seem to be legit. I'll try them locally to confirm.

The reason for the failures seem to be consistent: "FAIL: Unhandled LoginException: Timed out going through login screen. Cryptohome not mounted. OOBE not dismissed."

Looking at the logs of one of the failures, I see some errors that could help triage this:

- [26610:26610:0504/102420:ERROR:CONSOLE(1)] "Uncaught ReferenceError: cr is not defined", source:  (1)

- terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)

- [31913:31944:0504/103246:WARNING:drm_util.cc(190)] Unable to get cursor width capability: Invalid argument

- [32001:32015:0504/103253:ERROR:drm_gpu_display_manager.cc(172)] There is no display with ID 0
[26610:26610:0504/103253:ERROR:display_error_observer_chromeos.cc(63)] Failed to configure the following display(s):
[26610:26610:0504/103253:ERROR:display_error_observer_chromeos.cc(65)] - Display with ID = 0, and EDID = .
 
Owner: afakhry@chromium.org
Status: Started (was: Untriaged)
The UI doesn't even start on the peach_pit device. I will need to bisect....
Cc: osh...@chromium.org afakhry@chromium.org spang@chromium.org
Labels: -Type-Bug Type-Bug-Regression
Owner: lionel.g...@intel.com
Status: Assigned (was: Started)
Bisect ended ... This CL is the culprit https://codereview.chromium.org/1914343003.
Assigning to the owner. This failure is likely to make it to the PFQ soon unfortunately.

Project Member

Comment 3 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7

commit 5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7
Author: lionel.g.landwerlin <lionel.g.landwerlin@intel.com>
Date: Thu May 05 09:23:39 2016

Revert of ash: reset color management when new screens are hotplugged (patchset #3 id:30009 of https://codereview.chromium.org/1914343003/ )

Reason for revert:
This is causing issues on ARM/exynos5420-peach-pit Chromebook.
Let's revert this for now as I don't have a device to investigate.

BUG= 609256 

Original issue's description:
> ash: reset color management when new screens are plugged
>
> With the DRM drivers on ChromeOS, the color management tables and matrices
> are stored at the pipe level (part of the display hardware that is
> configurable regardless of the actual connector it is attached to). This
> allows display configuration to remain active while different processes are
> using the driver (for example switching VT).
>
> As a result, when an external screen is connected to a Chromebook, a given
> color configuration might be applied to it and remain stored in the driver
> after the screen is disconnected. If another external screen is now
> connected the previously applied color management will remain if there is
> not a profile for that display.
>
> This change takes care of resetting the color management matrices/tables on
> newly connected screen before we apply a new configuration.
>
> BUG= 495196 
> TEST=Manual testing with hotplugging of a display and identify correct
> behavior.
>
> Committed: https://crrev.com/5932a0131851f35b74be5d2fc86a3834defd4d8c
> Cr-Commit-Position: refs/heads/master@{#391491}

TBR=robert.bradford@intel.com,oshima@chromium.org,spang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 495196 

Review-Url: https://codereview.chromium.org/1945353004
Cr-Commit-Position: refs/heads/master@{#391781}

[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ash/display/display_color_manager_chromeos.cc
[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ash/display/display_color_manager_chromeos_unittest.cc
[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ui/ozone/platform/drm/gpu/drm_device.cc
[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ui/ozone/platform/drm/gpu/drm_device.h
[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ui/ozone/platform/drm/gpu/drm_display.cc
[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h
[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/5f1b82e8460a3d4d0a45346cdcdf5862be27c2c7/ui/ozone/platform/drm/gpu/mock_drm_device.h

Let's revert https://codereview.chromium.org/1914343003 for now.
I've tested this on several Intel Chromebook (running different kernel versions),  I'm wondering if this could be an issue in the exynos drm driver.
Cc: robert.b...@intel.com
Could you paste more of the traces on this bug?
Thanks!
Project Member

Comment 7 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af25197088e372b01dbb1ea7b7793e5c1e404d2

commit 7af25197088e372b01dbb1ea7b7793e5c1e404d2
Author: lionel.g.landwerlin <lionel.g.landwerlin@intel.com>
Date: Thu May 05 15:44:33 2016

Reland: ash: reset color management when new screens are plugged

Reland with fix for platforms that don't support drmModeCrtcSetGamma.

With the DRM drivers on ChromeOS, the color management tables and matrices
are stored at the pipe level (part of the display hardware that is
configurable regardless of the actual connector it is attached to). This
allows display configuration to remain active while different processes are
using the driver (for example switching VT).

As a result, when an external screen is connected to a Chromebook, a given
color configuration might be applied to it and remain stored in the driver
after the screen is disconnected. If another external screen is now
connected the previously applied color management will remain if there is
not a profile for that display.

This change takes care of resetting the color management matrices/tables on
newly connected screen before we apply a new configuration.

BUG= 495196 , 609256 
TEST=Manual testing with hotplugging of a display and identify correct
behavior.

Committed: https://crrev.com/5932a0131851f35b74be5d2fc86a3834defd4d8c
Cr-Commit-Position: refs/heads/master@{#391491}

Review-Url: https://codereview.chromium.org/1914343003
Cr-Commit-Position: refs/heads/master@{#391810}

[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ash/display/display_color_manager_chromeos.cc
[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ash/display/display_color_manager_chromeos_unittest.cc
[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ui/ozone/platform/drm/gpu/drm_device.cc
[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ui/ozone/platform/drm/gpu/drm_device.h
[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ui/ozone/platform/drm/gpu/drm_display.cc
[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h
[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/7af25197088e372b01dbb1ea7b7793e5c1e404d2/ui/ozone/platform/drm/gpu/mock_drm_device.h

Thanks for the fix. The peach_pit-tot-chrome-pfq-informational builder is green again. However the PFQ is not; the fix hasn't made it there yet.
Status: Fixed (was: Assigned)
PFQ turned green with the fix in.
Blocking: 609403
Blocking: 609199
Blocking: 594034
Blocking: 609201
Blocking: 609206
Blocking: 592052
Blocking: 609190
Blocking: 609196
Blocking: 609400
Blocking: 599173
Blocking: 599172
Blocking: 609401
Blocking: 609181
Bulk verified
Status: Verified (was: Fixed)
bulk verified
Blocking: -599172
Blocking: 599172
Issue 599172 has been merged into this issue.

Sign in to add a comment