New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609255 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit 20 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

chrome://downloads layout doesn't accommodate long interrupt reason strings

Project Member Reported by asanka@chromium.org, May 4 2016

Issue description

See the attached screenshot.

The longer interrupt reason descriptions can take up multiple lines and are intended to be more descriptive than the short messages used for the download shelf.

 
image.png
22.6 KB View Download
As a short term measure we are going to switch to using short messages for the chrome://downloads page. But we should fix the layout and revert to using the longer messages in the longer term.

Comment 2 by dbeam@chromium.org, May 5 2016

asanka@: are you owning this or do you want me to?
Not owning since my plate is full and can't material design my way out of a wet paper bag.

Project Member

Comment 4 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b03831ed8a4c6b20f60dfbc7b8bccae04bbfd7db

commit b03831ed8a4c6b20f60dfbc7b8bccae04bbfd7db
Author: asanka <asanka@chromium.org>
Date: Thu May 05 16:40:06 2016

[Downloads] Use a shorter status string in chrome://downloads.

R=dbeam@chromium.org
BUG=609255

Review-Url: https://codereview.chromium.org/1954553002
Cr-Commit-Position: refs/heads/master@{#391828}

[modify] https://crrev.com/b03831ed8a4c6b20f60dfbc7b8bccae04bbfd7db/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc

Labels: -M-52 M-51
Status: Fixed (was: Available)
Going to mark and fixed so that we can pull this up to M-51 if necessary. I'll re-open the issue after the merge for the M-52+ portion of the fix.

Comment 6 by asanka@chromium.org, May 12 2016

Cc: asanka@chromium.org
 Issue 608549  has been merged into this issue.

Comment 7 by asanka@chromium.org, May 12 2016

Labels: Merge-Request-51
Requesting merge. This is a small low-risk change that has been baking in Canary for a while now. The change was requested by UI-review, and doesn't involve any string changes (the strings are already there, Chrome will just use a different set of strings than it currently does).

Comment 8 by tin...@google.com, May 12 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Owner: asanka@chromium.org
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 9 by gov...@chromium.org, May 12 2016

Please merge your change to M51 branch 2704 before 5:00 PM PST, Monday (05/16/16), so we can take it in for next week LAST M51 beta release. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8ebc5cdb9aa2f7ee255bf80fa61ad3455dc508

commit ff8ebc5cdb9aa2f7ee255bf80fa61ad3455dc508
Author: Asanka Herath <asanka@chromium.org>
Date: Thu May 12 17:40:46 2016

[Merge M51][Downloads] Use a shorter status string in chrome://downloads.

R=dbeam@chromium.org
BUG=609255

Review-Url: https://codereview.chromium.org/1954553002
Cr-Commit-Position: refs/heads/master@{#391828}
(cherry picked from commit b03831ed8a4c6b20f60dfbc7b8bccae04bbfd7db)

Review URL: https://codereview.chromium.org/1976603003 .

Cr-Commit-Position: refs/branch-heads/2704@{#524}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/ff8ebc5cdb9aa2f7ee255bf80fa61ad3455dc508/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc

Labels: -Hotlist-Merge-Approved
Labels: Needs-Feedback
Could anyone let us know is there any steps to verify this issue from chrome TE end. Unable to test this issue manually in downloading large memory file. Observed no interruption and the file keeps downloading without any error message under Chrome://Downloads.

Thanks!
You'll need to interrupt the download in some fashion. For example, on a Windows machine, start a large download and then disable the internet connection or disconnect from the network. This should result in the download getting into an error state.

The resulting error message on chrome://downloads should look like "Failed - <short error message>" as opposed to "<long description>."
Labels: -Needs-Feedback
Owner: ----
Status: Available (was: Fixed)
Also re-opening for the proper fix now that temporary fix is in M51.
Blocking: -7648
Marking as not blocking resumption.

Comment 16 Deleted

Project Member

Comment 17 by sheriffbot@chromium.org, Aug 3 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: aboss@chromium.org
Status: Assigned (was: Untriaged)
Owner: nancygao@chromium.org

Sign in to add a comment