New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609254 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

TabStripControllerTest.CorrectMouseHoverBehavior fails with Material Design enabled

Project Member Reported by shrike@chromium.org, May 4 2016 
The test hard-coded coordinates that were based on old default tab widths.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd

commit a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd
Author: shrike <shrike@chromium.org>
Date: Wed May 04 23:21:56 2016

[Mac][Material Design] Fix TabStripController test that fails under MD.

This cl fixes a bug in one of the TabStripController unit tests. The
test used hard-coded mouse coordinates which no longer work because of
the new max tab width in Material Design.

This cl also fixes a bug where the new Material Design max tab width
was being used on non-MD.

R=avi@chromium.org
BUG= 609254 

Review-Url: https://codereview.chromium.org/1946993004
Cr-Commit-Position: refs/heads/master@{#391684}

[modify] https://crrev.com/a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h
[modify] https://crrev.com/a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd/chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm

Comment 2 by shrike@chromium.org, May 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment