zoom settings are no longer applied after redirection |
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2724.0 Safari/537.36 Steps to reproduce the problem: 1. Start Gmail. The URL will be https://mail.google.com/mail/u/0/#inbox 2. Set zoom to 150% 3. Go to http://www.gmail.com. This will redirect you to the above URL. What is the expected behavior? Zoom is 150% What went wrong? Page has no zoom. The hot dogs menu lies and says that zoom is 150%. Did this work before? Yes A couple of days ago. Still works in dev channel 52.0.2716.0 Chrome version: 52.0.2724.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0 This almost certainly has the same root cause as issue 608798
,
May 5 2016
Thanks for the report. CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/d20680c83c603d50678a6be1e1f389c25783ea86..7d8ce7003186698ce565f6eb59bf7027a2707f22 seeing some changes to page zoom in https://chromium.googlesource.com/chromium/src/+/64951906c6fb59b33a63313f98819bbafe9eebe2, wjmaclean@, Could you please check the above issue & help us in finding an owner it its not yours. Broken in M52 Good build : 52.0.2720.0 Bad build : 52.0.2721.0 Able to reproduce this issue on Win7, Mac OS X 10.11.4, Ubuntu 14.04 using Chrome Canary #52.0.2724.0
,
May 5 2016
I'll take a look ... it reproduces for me on ToT, and seems to almost certainly be related to my change.
,
May 6 2016
,
May 6 2016
I've found the cause of this, and unsurprisingly it has the same root cause as Issue 608798. I still need to write a test for the fix, but I expect we can land a fix on Monday.
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83f0cc71189113188073aaceee1e5e3dc46f8f08 commit 83f0cc71189113188073aaceee1e5e3dc46f8f08 Author: wjmaclean <wjmaclean@chromium.org> Date: Tue May 10 19:34:51 2016 RenderView needs to know zoom level for loading pages. Since r390755 (https://codereview.chromium.org/1804023002), RenderViewImpl keeps track of zoom level for pages so it can be applied when subframes load. This CL fixes a bug where RenderFrameImpl directly sets the zoom level on the WebView for loading pages, without going through RenderViewImpl. This can lead to incorrect zoom levels when redirects occur, or a page is loaded with middle-click. The effect is only seen when the page being loaded contains subframes. This CL forces the zoom change to go via RenderViewImpl. There is a slight behaviour change in this, as this will trigger RenderViewObserver::OnZoomLevelChanged() notifications for a loading page, where it did not before. However, at present the only consumer of this notification is WebViewPlugin, and it is not expected the change will cause problems in this case. BUG=608798, 609213 Review-Url: https://codereview.chromium.org/1953503005 Cr-Commit-Position: refs/heads/master@{#392684} [modify] https://crrev.com/83f0cc71189113188073aaceee1e5e3dc46f8f08/content/browser/iframe_zoom_browsertest.cc [modify] https://crrev.com/83f0cc71189113188073aaceee1e5e3dc46f8f08/content/renderer/render_frame_impl.cc
,
May 10 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ligim...@chromium.org
, May 4 2016