New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609188 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The IPC Message 'GuestViewMsg_GuestDetached ' is not used anymore and should be removed.

Project Member Reported by ekaramad@chromium.org, May 4 2016

Issue description

This IPC message is currently being sent from GuesViewBase with no receiver end in the embedder process. The IPC message should be removed.
 
Cc: fsam...@chromium.org
/cc Fady, I believe this was removed with surfaceworker code?
No this IPC is necessary and has nothing to do with SurfaceWorker. This IPC is necesasry to advance the GuestViewContainer queue: https://code.google.com/p/chromium/codesearch#chromium/src/components/guest_view/renderer/guest_view_request.h&sq=package:chromium&type=cs&l=92&rcl=1462360936

We don't do anything interesting with the IPC, but we should at least verify that that is the IPC we're receiving. in GuestViewDetachRequest::HandleResponse.
Status: WontFix (was: Started)
Following comment #2 marking this bug as Won't Fix.
Ah, this is the response to detach, not the request to detach. I somehow thought this was the latter.

I'm adding a (d)check that GuestViewDetachRequest receives the correct IPC:
https://codereview.chromium.org/2092603002/

Sign in to add a comment