New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609187 link

Starred by 1 user
Status: Verified
Owner:
█ charliemooney@chromium.org
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Touchbot needs to support multiple trained locations to accomodate differences in the Allion robot

Reported by charliemooney@chromium.org, May 4 2016 
It looks like the tolerances are very close on the new Allion Touchbot, but not quite 100%.  So we need to re-train the nest positions for the Allion robot without breaking the original Google robot.  We should come up with a way to have a separate set of trained nest positions for each robot without having to maintain a separate patch/etc.  I suspect this can be done by querying the robot and determining which version it is.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/cc54d631156395497d3917dd3561f018a8b211bc

commit cc54d631156395497d3917dd3561f018a8b211bc
Author: root <root@localhost.(none)>
Date: Wed May 04 17:51:13 2016

Support multiple robots and add Allion's

This CL adds support for the touchbot class to select different
trained nest fingertip positions depending on the robot.  Each
robot has a database of parameters that can be queried, one of them
is a robot name parameter (number 2002).  By changing that parameter
using the web UI, the touchbot class will now be able to dynamically
pick between the trained points without having to have a separate
codebase for each robot.

BUG= chromium:609187 
TEST=manually tested

Change-Id: Ia0ccd44c3dcf2ff390dfd5903e64e2396e2e5c7a
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/342465

[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/palm_small.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/1round_14mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/2round_8mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/palm_large.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/thumb_small.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/1round_12mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/2round_10mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/zeroing_position.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/thumb_large.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/three_fingers.p
[modify] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/touchbot.py
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/2round_12mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/1round_14mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/1round_10mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/2round_14mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/1round_12mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/2round_14mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/thumb_small.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/1round_8mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/four_fingers.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/palm_small.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/1round_9mm.p
[copy] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/zeroing_position.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/1round_8mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/2round_10mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/1round_10mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/thumb_large.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/five_fingers.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/five_fingers.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/2round_9mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/palm_large.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/2round_9mm.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/four_fingers.p
[rename] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/google/1round_9mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/2round_8mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/2round_12mm.p
[add] https://crrev.com/cc54d631156395497d3917dd3561f018a8b211bc/touchbot/nest_locations/allion/three_fingers.p

Comment 2 by charliemooney@chromium.org, May 11 2016

Status: Fixed (was: Started)

Comment 3 by patricia@chromium.org, May 23 2016 

Bulk verified

Comment 4 by patricia@chromium.org, May 23 2016

Status: Verified (was: Fixed)
bulk verified
►

Sign in to add a comment