[Chromoting Waterfall] Remove ipc_mojo_unittests from running on the waterfall |
||
Issue descriptionWe started seeing failures on our waterfall for unittests we did not expect to be running (We should only run remoting tests here). The waterfall recipe file picks up all of the isolated files built which included the ipc_mojo_unittests isolated file. I tracked down why this is occuring and several changes were needed to get here: 1.) We have browser tests which rely on the browser_tests target. 2.) The browser_tests target has a huge number of dependencies, one of which ends up including content_tests.gypi. 3.) content_tests.gypi includes every target from ipc_mojo.gyp Everything was fine until a change on April 29th which added a new swarming target to the ipc_mojo.gyp file. Once this occurred, our waterfall started building and running the ipc_mojo_unittests in environments it may or may not be intended to run in.
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1c45086462b022a93f97ba8c5baffa72660310a commit b1c45086462b022a93f97ba8c5baffa72660310a Author: joedow <joedow@chromium.org> Date: Thu May 05 15:58:06 2016 Fixing a GYP include that caused ipc_mojo tests to be unintentionally built. This change fixes a problem the CRD team is seeing on their private waterfall. The issue is that the ipc_mojo_unittests swarming target (added on April 29th) is now being built for a number of un-related targets (including ours which needs browser_tests to be built). I've tracked this down to a gypi file which included all targets from ipc_mojo. Changing this to only pull a specific target fixes the problem. BUG= 609186 Review-Url: https://codereview.chromium.org/1953503002 Cr-Commit-Position: refs/heads/master@{#391813} [modify] https://crrev.com/b1c45086462b022a93f97ba8c5baffa72660310a/content/content_tests.gypi
,
May 5 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by joedow@chromium.org
, May 4 2016