New issue
Advanced search Search tips

Issue 609177 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 343579



Sign in to add a comment

DataReductionProxy should use QUIC only if QUIC is enabled globally

Project Member Reported by tbansal@chromium.org, May 4 2016

Issue description

Currently, DataReductionProxy (DRP) uses QUIC if Chromium is in the DRPQuic field trial. Additionally, DRP should check if QUIC is enabled globally or not, and use QUIC only if it is enabled globally.

This would bring DRP usage of QUIC closer to how Chromium uses QUIC in general.
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45

commit 9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45
Author: tbansal <tbansal@chromium.org>
Date: Wed May 11 18:32:45 2016

Enable QUIC for proxies only when QUIC is enabled

1. Remove |enable_quic_for_proxies| from
HttpNetworkSession::Params. Instead, use |enable_quic|.
This change brings QUIC proxy code closer to
the global QUIC code.

2. Do not plumb |enable_quic| down to Data Reduction
Proxy (DRP) IO Data. Instead, DRP reads |enable_quic| from
HttpNetworkSession::Params directly.

3. Chrome will use QUIC to connect to DRP if QUIC is enabled
globally and Chrome is in DRP QUIC field trial. With this change
 DRP will use a QUIC proxy only when it is initialized using client
config service (and not statically configured proxies).

BUG= 609177 

Review-Url: https://codereview.chromium.org/1862193002
Cr-Commit-Position: refs/heads/master@{#393002}

[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/chrome/browser/io_thread.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/chrome/browser/io_thread.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/chrome/browser/io_thread_unittest.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/cronet/android/cronet_data_reduction_proxy.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/ios/chrome/browser/ios_chrome_io_thread.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/ios/chrome/browser/ios_chrome_io_thread.mm
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/net/http/http_network_session.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/net/http/http_network_session.h
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/9bf2667a46fd3ba3f7c4f4c69d2217ca68959a45/net/quic/quic_network_transaction_unittest.cc

Comment 3 by bengr@chromium.org, May 12 2016

Is this fixed?
Status: Fixed (was: Started)
Blocking: 343579

Sign in to add a comment