[Accessibility] Media Router dialog has warning for AX_COLOR_01. |
|||||||||||
Issue descriptionAX_COLOR_01: Text elements should have a reasonable contrast ratio. This is an issue with the paper blue 500 and white colors. Per discussion with design, we'll use paper blue 700 instead, which passes the audit. More info at: https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules#ax_color_01 This is from the a11y developer tools extension audit.
,
May 4 2016
The grey used for subtext is also too light.
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7e4e8b18cd9846f1ce1d1a6a334a8b96648b832 commit e7e4e8b18cd9846f1ce1d1a6a334a8b96648b832 Author: apacible <apacible@chromium.org> Date: Wed May 04 20:44:23 2016 [Media Router WebUI] Make subtext color darker. The current color is between paper grey 500 and paper grey 600. This darkens the color to paper grey 600 to fix the AX_COLOR_01 warnings for the subtext. BUG= 609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1946823003 Cr-Commit-Position: refs/heads/master@{#391630} [modify] https://crrev.com/e7e4e8b18cd9846f1ce1d1a6a334a8b96648b832/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/e7e4e8b18cd9846f1ce1d1a6a334a8b96648b832/chrome/browser/resources/media_router/media_router_common.css
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c672ef5004a61ed85419fa924637a5630d2c78a commit 8c672ef5004a61ed85419fa924637a5630d2c78a Author: apacible <apacible@chromium.org> Date: Wed May 04 20:48:52 2016 [Media Router WebUI] Make blue color styling darker. Currently, paper blue 500 and white do not have enough contrast. This change replaces all usages of paper blue 500 with 700, which is the next darkest paper blue color that passes the accessibility audit. This fixes the AX_COLOR_01 warnings related to the blue color. BUG= 609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1950563003 Cr-Commit-Position: refs/heads/master@{#391633} [modify] https://crrev.com/8c672ef5004a61ed85419fa924637a5630d2c78a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/8c672ef5004a61ed85419fa924637a5630d2c78a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css [modify] https://crrev.com/8c672ef5004a61ed85419fa924637a5630d2c78a/chrome/browser/resources/media_router/media_router_common.css
,
May 4 2016
,
May 5 2016
Did a more thorough audit using the dev tools extension: For non-blocking issues, the action links (e.g. learn more) need more contrast to the dark grey banner background. For blocking issues, the red header background needs to be darker. For the cast mode list, the teal header background needs to be darker.
,
May 6 2016
Merge request for revisions #3 and #4. https://codereview.chromium.org/1946823003 https://codereview.chromium.org/1950563003 A third revision (also to be requested for merge) is currently pending review. https://codereview.chromium.org/1952213005/
,
May 6 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dd476b2fabedb95f0ff1646c6d8c532e08fd27d commit 1dd476b2fabedb95f0ff1646c6d8c532e08fd27d Author: Jennifer Apacible <apacible@google.com> Date: Fri May 06 16:40:47 2016 [Media Router WebUI] Make subtext color darker. The current color is between paper grey 500 and paper grey 600. This darkens the color to paper grey 600 to fix the AX_COLOR_01 warnings for the subtext. BUG= 609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1946823003 Cr-Commit-Position: refs/heads/master@{#391630} (cherry picked from commit e7e4e8b18cd9846f1ce1d1a6a334a8b96648b832) Review URL: https://codereview.chromium.org/1959723002 . Cr-Commit-Position: refs/branch-heads/2704@{#421} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/1dd476b2fabedb95f0ff1646c6d8c532e08fd27d/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/1dd476b2fabedb95f0ff1646c6d8c532e08fd27d/chrome/browser/resources/media_router/media_router_common.css
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43e542e1b621d501719966c6742b7d6f13dc5433 commit 43e542e1b621d501719966c6742b7d6f13dc5433 Author: Jennifer Apacible <apacible@google.com> Date: Fri May 06 17:24:27 2016 [Media Router WebUI] Make blue color styling darker. Currently, paper blue 500 and white do not have enough contrast. This change replaces all usages of paper blue 500 with 700, which is the next darkest paper blue color that passes the accessibility audit. This fixes the AX_COLOR_01 warnings related to the blue color. BUG= 609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1950563003/ Cr-Commit-Position: refs/heads/master@{#391633} (cherry picked from commit 8c672ef5004a61ed85419fa924637a5630d2c78a) Review URL: https://codereview.chromium.org/1956583003 . Cr-Commit-Position: refs/branch-heads/2704@{#424} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/43e542e1b621d501719966c6742b7d6f13dc5433/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/43e542e1b621d501719966c6742b7d6f13dc5433/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css [modify] https://crrev.com/43e542e1b621d501719966c6742b7d6f13dc5433/chrome/browser/resources/media_router/media_router_common.css
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01a6592cf9703eac1ec9a156efe4d1bc5470b019 commit 01a6592cf9703eac1ec9a156efe4d1bc5470b019 Author: apacible <apacible@chromium.org> Date: Fri May 06 19:32:14 2016 [Media Router WebUI] Fix remaining AX_COLOR_01 warnings. This change makes: - non-blocking issue button text lighter blue. - blocking issue header background darker red. - cast mode view header background darker teal. BUG= 609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1952213005 Cr-Commit-Position: refs/heads/master@{#392123} [modify] https://crrev.com/01a6592cf9703eac1ec9a156efe4d1bc5470b019/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.css [modify] https://crrev.com/01a6592cf9703eac1ec9a156efe4d1bc5470b019/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css
,
May 6 2016
,
May 9 2016
One more merge request for changes in #11.
,
May 9 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dcc2883863daff68ae61fa1359b86b75c7f4cb3 commit 0dcc2883863daff68ae61fa1359b86b75c7f4cb3 Author: Jennifer Apacible <apacible@google.com> Date: Mon May 09 18:34:27 2016 [Media Router WebUI] Fix remaining AX_COLOR_01 warnings. This change makes: - non-blocking issue button text lighter blue. - blocking issue header background darker red. - cast mode view header background darker teal. BUG= 609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review URL: https://codereview.chromium.org/1956353003 . Cr-Commit-Position: refs/branch-heads/2704@{#446} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/0dcc2883863daff68ae61fa1359b86b75c7f4cb3/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.css [modify] https://crrev.com/0dcc2883863daff68ae61fa1359b86b75c7f4cb3/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css
,
May 16 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by apaci...@chromium.org
, May 4 2016