Make master-side triggering failures entire build |
||||
Issue descriptionContext: issue 608167 In most of cases, if triggering failed on the master side, entire build must be red.
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/deb5d6a1e95e8f0a6ba97e37d17163d37e531729 commit deb5d6a1e95e8f0a6ba97e37d17163d37e531729 Author: nodir@chromium.org <nodir@chromium.org> Date: Mon May 09 15:44:27 2016 Fail build if triggering fails Introduce the concept of "fatal error" to AnnotatedCommand. In case of fatal errors, mark entire build as EXCEPTION and put the details in the fatal_errors log of the preamble. If 'critical' is True or absent in a triggering spec and triggering fails on the master side, it is a fatal error. R=vadimsh@chromium.org BUG= 609166 Review-Url: https://codereview.chromium.org/1949753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300505 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/deb5d6a1e95e8f0a6ba97e37d17163d37e531729/scripts/master/chromium_step.py [modify] https://crrev.com/deb5d6a1e95e8f0a6ba97e37d17163d37e531729/scripts/slave/recipe_modules/trigger/api.py
,
May 9 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87598 ------------------------------------------------------------------ r87598 | recipe-roller@chromium.org | 2016-05-09T16:02:54.291113Z -----------------------------------------------------------------
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c8547546cf8adeef2082c2840ad966fe7eb213e3 commit c8547546cf8adeef2082c2840ad966fe7eb213e3 Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Mon May 09 23:45:42 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/bee544abb82d45aa7e80c29aa1c2ef676003c7bf Remove non-subprocess42 code path. (iannucci@chromium.org) https://crrev.com/866db4322e55e91efbef9fcff02b188cceba8df3 triggering: add critical flag (nodir@chromium.org) R=dpranke@chromium.org,estaab@chromium.org,iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org BUG= 609166 , 522396 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1965583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300514 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/c8547546cf8adeef2082c2840ad966fe7eb213e3/infra/config/recipes.cfg
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/13eecb79ea9ddb6e44041ca55f12b49de67eb69f commit 13eecb79ea9ddb6e44041ca55f12b49de67eb69f Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Mon May 09 23:58:16 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/c8547546cf8adeef2082c2840ad966fe7eb213e3 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/bee544abb82d45aa7e80c29aa1c2ef676003c7bf Remove non-subprocess42 code path. (iannucci@chromium.org) https://crrev.com/866db4322e55e91efbef9fcff02b188cceba8df3 triggering: add critical flag (nodir@chromium.org) R=dpranke@chromium.org,iannucci@chromium.org,recipe-roller@chromium.org,estaab@chromium.org,nodir@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org BUG= 609166 , 522396 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1964783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300516 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/13eecb79ea9ddb6e44041ca55f12b49de67eb69f/infra/config/recipes.cfg
,
May 10 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87637 ------------------------------------------------------------------ r87637 | recipe-roller@chromium.org | 2016-05-10T00:03:23.095886Z -----------------------------------------------------------------
,
Jun 27 2016
,
Jun 27 2016
,
Nov 11 2016
Fixed a while ago |
||||
►
Sign in to add a comment |
||||
Comment 1 by no...@chromium.org
, May 4 2016