Change update.py to pull cmake 3.4.3 |
||
Issue descriptionupdate.py currently pulls cmake 3.2.2. Upstream wants to require 3.4.3 as of May 23 (in a bit over two weeks). We should upgrade our bots to 3.4.3 very soon so that if we run into issues (unlikely, but who knows), we can let upstream know about that. I can probably make some time for this on Friday. If one of you thinks we should do this earlier, feel free to lend a hand ;-) (Should be fairly easy: Upload binaries to http://commondatastorage.googleapis.com/chromium-browser-clang/index.html?path=tools/ , change update.py to pull the new version instead.) Looking at prior art https://bugs.chromium.org/p/chromium/issues/detail?id=494442#c34 I remember that it's important to build the mac binaries in a 10.9 VM.
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffe3e65a4d58f809a85d3716ead7daa9aa9df4ae commit ffe3e65a4d58f809a85d3716ead7daa9aa9df4ae Author: thakis <thakis@chromium.org> Date: Mon May 09 18:44:11 2016 clang tot bots: Update to cmake 3.4.3 The 3.4.3 zip file is identical to the 3.4.3 Windows zip on cmake.org. The Linux file is almost identical except that I removed doc/cmake/html and bin/ccmake and bin/cmake-gui. Mac is just the doc/, bin/, share/ folders in CMake.app/Contents (again with doc/cmake/html and ccmake and cmake-gui removed). BUG= 609162 Review-Url: https://codereview.chromium.org/1963773002 Cr-Commit-Position: refs/heads/master@{#392380} [modify] https://crrev.com/ffe3e65a4d58f809a85d3716ead7daa9aa9df4ae/tools/clang/scripts/update.py
,
May 9 2016
Looks like this was uneventful. |
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, May 9 2016