New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609138 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Convert ui::Event directly to blink::WebInputEvent

Project Member Reported by moshayedi@chromium.org, May 4 2016

Issue description

In CompositorMusConnection::OnWindowInputEvent we need to convert ui::Event to blink::WebInputEvent. We currently do this by first converting ui::Event to mojom::Event, and then using the mojom type converters we convert it to blink::WebInputEvent.

We will remove the ui::Event to mojom::Event type converters, so we need to convert ui::Event directly to mojom::Event.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/164cb9b90ff36afb164c3669973cadb71c92139f

commit 164cb9b90ff36afb164c3669973cadb71c92139f
Author: moshayedi <moshayedi@chromium.org>
Date: Mon May 09 18:33:51 2016

Convert ui::Event directly to blink::WebInputEvent.

In CompositorMusConnection::OnWindowInputEvent we need to convert ui::Event to
blink::WebInputEvent. Previously we did this by first converting ui::Event to
mojom::Event, and then using the mojom type converters we convert it to
blink::WebInputEvent.

We will remove the ui::Event to mojom::Event type converters. This CL adds
support for direct conversion from ui::Event to blink::WebInputEvent.

BUG= 609138 

Review-Url: https://codereview.chromium.org/1949893003
Cr-Commit-Position: refs/heads/master@{#392376}

[modify] https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f/mojo/BUILD.gn
[modify] https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f/mojo/converters/blink/BUILD.gn
[modify] https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f/mojo/converters/blink/DEPS
[modify] https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f/mojo/converters/blink/blink_input_events_type_converters.cc
[modify] https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f/mojo/converters/blink/blink_input_events_type_converters.h
[add] https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f/mojo/converters/blink/blink_input_events_type_converters_unittest.cc

Status: Fixed (was: Started)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment