DCHECK when ObjCPropertyReleaser doesn't find any properties |
||||
Issue descriptionOn iOS we got rid of all properties in main_controller.mm, but forgot to remove the ObjCPropertyReleaser. In order to prevent omissions like these, can we add a DCHECK in ObjCPropertyReleaser's destructor making sure it is only used in class that actually do contain properties?
,
May 9 2016
Test CL at https://codereview.chromium.org/1961013002 Note that Chrome immediately DCHECKs easily then :) In a first step, instead of DCHECK, I'd log the class name and run all our tests. Then the logs would list most offenders and we would need to clean it up before actually DCHECKing.
,
May 9 2016
The test CL looks good. Now we need to fix Chromium OS X/iOS :)
,
Apr 19 2017
,
Sep 12 2017
The only place where ObjCPropertyReleaser is used is HandoffManager, which is shared between Mac and iOS. Do we still care about fixing this issue?
,
Sep 13 2017
Nope, and I'm actually disappointed that ObjCPropertyReleaser is still used on iOS. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jif@chromium.org
, May 4 2016