New issue
Advanced search Search tips

Issue 609135 link

Starred by 2 users
Status: Fixed
Owner:
melandory@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Auto signin first run experience dialog should be marked as shown only if user makes the decisions.

Project Member Reported by melandory@chromium.org, May 4 2016 
Auto signin first run experience dialog should be marked as shown only if user makes the decisions, which means user has clicked either "Turn off" or "Ok, got it" button.

Comment 2 by melandory@chromium.org, May 4 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, May 4 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bec7c01efcdf55695569eb6757c36326a64aad2

commit 5bec7c01efcdf55695569eb6757c36326a64aad2
Author: Tatiana Gornak <melandory@chromium.org>
Date: Wed May 04 23:24:42 2016

[Smart Lock] Stop showing auto signin first run only after user decision received.

BUG= 609135 

Review-Url: https://codereview.chromium.org/1952723002
Cr-Commit-Position: refs/heads/master@{#391670}
(cherry picked from commit 8c60b4a72614ac2a44e45c8d4f3c5eb60553a8ef)

Review URL: https://codereview.chromium.org/1945723004 .

Cr-Commit-Position: refs/branch-heads/2704@{#379}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/5bec7c01efcdf55695569eb6757c36326a64aad2/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc
[modify] https://crrev.com/5bec7c01efcdf55695569eb6757c36326a64aad2/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/718778c0679c8ef6e3e2df467eba0fee1d72202c

commit 718778c0679c8ef6e3e2df467eba0fee1d72202c
Author: melandory <melandory@chromium.org>
Date: Thu May 05 06:02:59 2016

[Smart Lock] Propagate click on positive button to native counterpart.

Click on positive button ("Ok, got it") in auto signin first run
experience dialog should be propagated to native counterpart.

BUG= 609135 

Review-Url: https://codereview.chromium.org/1954613002
Cr-Commit-Position: refs/heads/master@{#391768}

[modify] https://crrev.com/718778c0679c8ef6e3e2df467eba0fee1d72202c/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java
Project Member

Comment 6 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82aee9a1d1627a4ace0ea476881713515797e79c

commit 82aee9a1d1627a4ace0ea476881713515797e79c
Author: Tatiana Gornak <melandory@chromium.org>
Date: Thu May 05 06:25:51 2016

[Smart Lock] Propagate click on positive button to native counterpart.

Click on positive button ("Ok, got it") in auto signin first run
experience dialog should be propagated to native counterpart.

BUG= 609135 

Review-Url: https://codereview.chromium.org/1954613002
Cr-Commit-Position: refs/heads/master@{#391768}
(cherry picked from commit 718778c0679c8ef6e3e2df467eba0fee1d72202c)

Review URL: https://codereview.chromium.org/1952673004 .

Cr-Commit-Position: refs/branch-heads/2704@{#381}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/82aee9a1d1627a4ace0ea476881713515797e79c/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java

Comment 7 by melandory@chromium.org, Aug 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment