New issue
Advanced search Search tips

Issue 609134 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in v8::Object::FindInstanceInPrototypeChain

Project Member Reported by ClusterFuzz, May 4 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5570573001818112

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x0000ffff8007
Crash State:
  v8::Object::FindInstanceInPrototypeChain
  blink::DOMWindowV8Internal::focusOriginSafeMethodGetterCallback
  v8::internal::PropertyCallbackArguments::Call
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=387601:387928

Minimized Testcase (1.95 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96kG8cKEkKIrOccINbivuAL_ckUNL0CQXs_LWLW-ABc6NK38XwnV9KCzonHZ58vlf1PBy51GvcwKY60-ioW29nmdMAFcOTl0Uaf0jY8CIJe4jJqw1X6kYGAy9baG-gvEnAKN-4WNIKEYAnUF-4cAbHshezosA

Filer: ochang

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, May 5 2016

Labels: Pri-1

Comment 2 by f...@chromium.org, May 6 2016

Components: Infra>Client>V8
Labels: M-52
Owner: jochen@chromium.org
Status: Assigned (was: Available)
jochen@, would you be able to investigate this? you have some CLs in the range, although i'm honestly doubtful either is the culprit.
i think this is high, as it allows for controlling the "this" value of a v8::Object from js
Cc: verwa...@chromium.org
Labels: OS-All
Labels: -M-52 M-50
Project Member

Comment 6 by sheriffbot@chromium.org, May 6 2016

Labels: -Security_Impact-Head Security_Impact-Stable

Comment 8 by f...@chromium.org, May 6 2016

Labels: -Security_Severity-Medium Security_Severity-High
Thanks Jochen. Bumping severity to high.
Status: Fixed (was: Assigned)
Project Member

Comment 10 by ClusterFuzz, May 6 2016

Labels: Merge-Triage M-51
Adding Merge-Triage label for tracking purposes.

Once your fix had sufficient bake time (on canary, dev as appropriate), please nominate your fix for merge by adding the Merge-Requested label.

When your merge is approved by the release manager, please start merging with higher milestone label first. Make sure to re-request merge for every milestone in the label list. You can get branch information on omahaproxy.appspot.com.

- Your friendly ClusterFuzz
Project Member

Comment 11 by sheriffbot@chromium.org, May 7 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by ClusterFuzz, May 10 2016

ClusterFuzz has detected this issue as fixed in range 392292:392298.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5570573001818112

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x0000ffff8007
Crash State:
  v8::Object::FindInstanceInPrototypeChain
  blink::DOMWindowV8Internal::focusOriginSafeMethodGetterCallback
  v8::internal::PropertyCallbackArguments::Call
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=387601:387928
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=392292:392298

Minimized Testcase (1.95 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96kG8cKEkKIrOccINbivuAL_ckUNL0CQXs_LWLW-ABc6NK38XwnV9KCzonHZ58vlf1PBy51GvcwKY60-ioW29nmdMAFcOTl0Uaf0jY8CIJe4jJqw1X6kYGAy9baG-gvEnAKN-4WNIKEYAnUF-4cAbHshezosA

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Assigned (was: Fixed)
still something more to do here.
Cc: -verwa...@chromium.org verwa...@chromium.orgm hablich@chromium.org
Does it make sense to already merge the CL in #7?
next CL is coming in any second now :)
Project Member

Comment 17 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ced492a6df0359e18ffa07cad95a4fcf5595c318

commit ced492a6df0359e18ffa07cad95a4fcf5595c318
Author: jochen <jochen@chromium.org>
Date: Wed May 11 11:27:33 2016

Don't compile code for LoadICs if the receiver is primitive

BUG= chromium:609134 
R=verwaest@chromium.org

Review-Url: https://codereview.chromium.org/1966853004
Cr-Commit-Position: refs/heads/master@{#36168}

[modify] https://crrev.com/ced492a6df0359e18ffa07cad95a4fcf5595c318/src/ic/ic.cc
[modify] https://crrev.com/ced492a6df0359e18ffa07cad95a4fcf5595c318/test/cctest/test-accessors.cc

Project Member

Comment 18 by ClusterFuzz, May 11 2016

Status: Fixed (was: Assigned)
Please mark security bugs as fixed as soon as the fix lands, and before requesting merges.

- Your friendly ClusterFuzz
now it's fixed
Michael, can you take care of merging once this baked a bit?
Labels: -Merge-Triage merge-review-5.1 merge-review-5.0
Labels: -merge-review-5.1 -merge-review-5.0 Merge-Approved-5.0 Merge-Approved-5.1
Cc: -verwa...@chromium.orgm verwa...@chromium.org
Components: -Infra>Client>V8 Blink>JavaScript>Runtime
Project Member

Comment 26 by bugdroid1@chromium.org, May 18 2016

Labels: merge-merged-5.1
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a

commit bf95fd960eaa78da2edfe5d7ba26169cb1c0433a
Author: Toon Verwaest <verwaest@chromium.org>
Date: Wed May 18 08:15:58 2016

Version 5.1.281.41 (cherry-pick)

Convert primitive receivers for API property callbacks
Don't compile code for LoadICs if the receiver is primitive
Interceptors expect the receiver to always be an JSReceiver.

BUG= chromium:609134 
LOG=N
R=hablich@chromium.org

Review URL: https://codereview.chromium.org/1993633002 .

Cr-Commit-Position: refs/branch-heads/5.1@{#50}
Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{#35282}

[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/include/v8-version.h
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/src/accessors.cc
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/src/factory.cc
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/src/ic/ic.cc
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/src/objects-inl.h
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/src/objects.cc
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/src/objects.h
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/test/cctest/test-accessors.cc
[modify] https://crrev.com/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a/test/cctest/test-api-interceptors.cc

Project Member

Comment 27 by sheriffbot@chromium.org, May 21 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: ofrobots@google.com
Labels: -Merge-Approved-5.0 -Merge-Approved-5.1
Is this something node needs?
Labels: Release-0-M51
Yes, the fix would be useful for Node too; although I don't think this is high-severity in the Node case.
Labels: backport-review
Project Member

Comment 32 by sheriffbot@chromium.org, Aug 17 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Backport-review NodeJS-Backport-Review
Project Member

Comment 34 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 35 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic
Labels: -NodeJS-Backport-Review NodeJS-Backport-Done

Sign in to add a comment