deviceorientationabsolute not according to spec on ChromeOS |
||||||
Issue descriptionCONSUMER_TYPE_DEVICE_ORIENTATION_ABSOLUTE is currently NOTIMPLEMENTED on ChromeOS. However if ChromeOS cannot provide absolute orientation data (which looks like is the case) it should actually fire a null-event as according to the spec (http://w3c.github.io/deviceorientation/spec-source-orientation.html)
,
May 4 2016
this can be done similarly to https://codereview.chromium.org/1915273003/
,
May 4 2016
Jon, would you be able to take a look at this?
,
May 4 2016
Ah nice catch, I'll add a similar event to the change in #2
,
May 4 2016
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/123238ab16647ff1fd69a664844522793eae69b6 commit 123238ab16647ff1fd69a664844522793eae69b6 Author: jonross <jonross@chromium.org> Date: Tue May 10 19:13:43 2016 Make deviceorientationabsolute confrom with spec on Chromium OS Absolute device orientation cannot be provided on Chromium OS machines. This update sends a one-off null event when deviceorientationabsolute is requesteed. This conforms with the spec: http://w3c.github.io/deviceorientation/spec-source-orientation.html TEST=http://timvolodine.github.io/deviceorientation-test/ BUG= 609131 Review-Url: https://codereview.chromium.org/1947963003 Cr-Commit-Position: refs/heads/master@{#392674} [modify] https://crrev.com/123238ab16647ff1fd69a664844522793eae69b6/content/browser/device_sensors/data_fetcher_shared_memory_chromeos.cc
,
May 10 2016
,
May 19 2016
,
May 23 2016
Bulk verified
,
May 23 2016
bulk verified |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by timvolod...@chromium.org
, May 4 2016