In order to support our MD refresh in Issue 609109, let's carve out: - the gray background - the white fakebox - the layout changes according to spec: https://folio.googleplex.com/chrome-ux/mocks/335-NTP-Zine/Zine/_UI%20Review/spec#%2FSpec-zine.png - the bookmarks and recents bar in MD as per the non-approved mock: https://folio.googleplex.com/nepper/zine/material%20design#%2FClank%20NTP%20MD.png We should have these changes behind a separate feature flag, enabled the code by default on trunk and be ready to pull the kill switch if required.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61ca55404d889f1c66821603075ecd096958e5b7 commit 61ca55404d889f1c66821603075ecd096958e5b7 Author: maybelle <maybelle@chromium.org> Date: Sat May 07 08:01:28 2016 Update NTP to new material design spec. Also add a feature flag so we can disable if necessary. Screenshots here of NTP with snippets off and snippets on: http://imgur.com/a/Wd04S BUG= 609112 Review-Url: https://codereview.chromium.org/1960553003 Cr-Commit-Position: refs/heads/master@{#392250} [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/res/layout/new_tab_page_recycler_view.xml [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/res/layout/new_tab_page_view.xml [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java [add] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/android/java_sources.gni [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7/chrome/browser/android/chrome_feature_list.h
Woot! Anything missing here, or can this be marked fixed?
Yes, still a couple of bug fixes that need to land before we can claim it's fixed
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d commit db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d Author: maybelle <maybelle@chromium.org> Date: Mon May 09 18:51:55 2016 Revert of Update NTP to new material design spec. (patchset #2 id:20001 of https://codereview.chromium.org/1960553003/ ) Reason for revert: Regression cause in incognito: https://bugs.chromium.org/p/chromium/issues/detail?id=610192 Original issue's description: > Update NTP to new material design spec. > > Also add a feature flag so we can disable if necessary. > > Screenshots here of NTP with snippets off and snippets on: > http://imgur.com/a/Wd04S > > BUG= 609112 > > Committed: https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7 > Cr-Commit-Position: refs/heads/master@{#392250} TBR=bauerb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 609112 Review-Url: https://codereview.chromium.org/1962063002 Cr-Commit-Position: refs/heads/master@{#392382} [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/res/layout/new_tab_page_recycler_view.xml [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/res/layout/new_tab_page_view.xml [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java [delete] https://crrev.com/6b7a69cb01b23770aa0b6d5823d91315695d7a7c/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/android/java_sources.gni [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d/chrome/browser/android/chrome_feature_list.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61 commit 3d283524e2c7f414a70d44c6d5dd1e86b60d3c61 Author: bauerb <bauerb@chromium.org> Date: Mon May 09 19:08:24 2016 Reland of Update NTP to new material design spec. (patchset #1 id:1 of https://codereview.chromium.org/1962063002/ ) Reason for revert: Not considered a Dev blocker; will be fixed in followup CL. Original issue's description: > Revert of Update NTP to new material design spec. (patchset #2 id:20001 of https://codereview.chromium.org/1960553003/ ) > > Reason for revert: > Regression cause in incognito: https://bugs.chromium.org/p/chromium/issues/detail?id=610192 > > Original issue's description: > > Update NTP to new material design spec. > > > > Also add a feature flag so we can disable if necessary. > > > > Screenshots here of NTP with snippets off and snippets on: > > http://imgur.com/a/Wd04S > > > > BUG= 609112 > > > > Committed: https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7 > > Cr-Commit-Position: refs/heads/master@{#392250} > > TBR=bauerb@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 609112 > > Committed: https://crrev.com/db02ce06cfb5cb341b4cb4152f1bf51c1c5ada3d > Cr-Commit-Position: refs/heads/master@{#392382} TBR=maybelle@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 609112 Review-Url: https://codereview.chromium.org/1958233002 Cr-Commit-Position: refs/heads/master@{#392387} [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/res/layout/new_tab_page_recycler_view.xml [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/res/layout/new_tab_page_view.xml [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java [add] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/android/java_sources.gni [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/3d283524e2c7f414a70d44c6d5dd1e86b60d3c61/chrome/browser/android/chrome_feature_list.h
May, in case there are things others can pick up: would you file bugs and mark them as blockers on this issue? Thanks :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b9de767b07897905058dad8f5f9c4651c186d26 commit 4b9de767b07897905058dad8f5f9c4651c186d26 Author: maybelle <maybelle@chromium.org> Date: Fri May 13 16:52:22 2016 Fix background color for incognito tabs when material design is enabled BUG= 609112 Review-Url: https://codereview.chromium.org/1969403008 Cr-Commit-Position: refs/heads/master@{#393552} [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java [modify] https://crrev.com/4b9de767b07897905058dad8f5f9c4651c186d26/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
Is anything remaining here, or can we mark this fixed? :)
I think it's fixed (I'm not aware of remaining issues, but I would track those in a followup bug anyway).
Comment 1 by nepper@chromium.org
, May 4 2016