New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609108 link

Starred by 8 users
Status: Assigned
Owner:
hbos@chromium.org
Cc:
hta@chromium.org
█ emadomara@chromium.org
webrtc-network-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Checking equality of an RTCCertificate and its IndexedDB clone in JavaScript tests.

Project Member Reported by hbos@chromium.org, May 4 2016 
|generateAndCloneCertificate| of chrome/test/data/webrtc/indexeddb.js introduced in https://codereview.chromium.org/1949033002/ should perform a value-equality check between the original certificate and its clone.

It would be nice to verify that the certificate loaded from IndexedDB is value-equal to the original certificate stored there. This should not block certificate cloning though since WebRTC tests already test cloning and verify equality.

In order to use |window.internals.rtcCertificateEquals|, |windows.internals| must be exposed to WebRtcBrowserTest.

Alternatively, |getStats| could perhaps be used to check if the certificate of two peer connections are equal with a string compare. But |rtcCertificateEquals| would be preferred.

Comment 1 by pthatcher@chromium.org, May 9 2016

Labels: WebrtcTriaged
Is it correct to mark this triaged since you assigned it to yourself?

Comment 2 by hbos@chromium.org, May 10 2016 

Sure

Comment 3 by fi...@appear.in, Oct 7 2016 

won't the new RTCCertificate.fingerprints allow this in an easier way? Just got merged into the spec in https://github.com/w3c/webrtc-pc/pull/738

Comment 4 by hbos@chromium.org, Oct 7 2016 

Good idea! We should implement RTCCertificate.fingerprint.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149d40a4e451675bbed7a093e56d40fb11f73196

commit 149d40a4e451675bbed7a093e56d40fb11f73196
Author: hbos <hbos@chromium.org>
Date: Thu Jun 08 14:40:35 2017

RTCCertificate.getFingerprints added (exposed to the web).

Spec: https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtccertificate-getfingerprints

Intent to Implement & Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h8qqS5sI-ig

BUG=698313, 609108

Review-Url: https://codereview.chromium.org/2828563002
Cr-Commit-Position: refs/heads/master@{#477962}

[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/chrome/browser/media/webrtc/webrtc_browsertest_base.h
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/chrome/test/data/webrtc/indexeddb.js
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/chrome/test/data/webrtc/peerconnection.js
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/content/renderer/media/rtc_certificate.cc
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/content/renderer/media/rtc_certificate.h
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-generateCertificate-expected.txt
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-generateCertificate.html
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/Source/modules/peerconnection/RTCCertificate.cpp
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/Source/modules/peerconnection/RTCCertificate.h
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/Source/modules/peerconnection/RTCCertificate.idl
[add] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/Source/modules/peerconnection/RTCDtlsFingerprint.idl
[modify] https://crrev.com/149d40a4e451675bbed7a093e56d40fb11f73196/third_party/WebKit/public/platform/WebRTCCertificate.h
►

Sign in to add a comment