The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/609b5e5e30b719805dfe31f2f44f61d1293e83e8

commit 609b5e5e30b719805dfe31f2f44f61d1293e83e8
Author: jochen <jochen@chromium.org>
Date: Fri May 06 07:30:52 2016

Add GN target for the sample shell

I want to stop using d8 from the chromium build, so we could potentially
use it for running tests.

BUG=chromium:609107
R=machenbach@chromium.org
LOG=n

Review-Url: https://codereview.chromium.org/1944353002
Cr-Commit-Position: refs/heads/master@{#36060}

[modify] https://crrev.com/609b5e5e30b719805dfe31f2f44f61d1293e83e8/BUILD.gn
[modify] https://crrev.com/609b5e5e30b719805dfe31f2f44f61d1293e83e8/gypfiles/toolchain.gypi
[modify] https://crrev.com/609b5e5e30b719805dfe31f2f44f61d1293e83e8/samples/samples.gyp

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/19a8e09cc0bafa5071c52243234bfc8512210065

commit 19a8e09cc0bafa5071c52243234bfc8512210065
Author: jochen <jochen@chromium.org>
Date: Fri May 06 10:39:28 2016

Add GN targets for samples

BUG=chromium:609107
R=machenbach@chromium.org
LOG=n

Review-Url: https://codereview.chromium.org/1955723003
Cr-Commit-Position: refs/heads/master@{#36072}

[modify] https://crrev.com/19a8e09cc0bafa5071c52243234bfc8512210065/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/369dcca7a543318194d66aaca4cb71e90bff9240

commit 369dcca7a543318194d66aaca4cb71e90bff9240
Author: hablich <hablich@chromium.org>
Date: Mon May 09 07:17:26 2016

Revert of Add GN targets for samples (patchset #1 id:1 of https://codereview.chromium.org/1955723003/ )

Reason for revert:
Blocks roll: https://codereview.chromium.org/1956223002/

Original issue's description:
> Add GN targets for samples
>
> BUG=chromium:609107
> R=machenbach@chromium.org
> LOG=n
>
> Committed: https://crrev.com/19a8e09cc0bafa5071c52243234bfc8512210065
> Cr-Commit-Position: refs/heads/master@{#36072}

TBR=machenbach@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:609107
LOG=n

Review-Url: https://codereview.chromium.org/1955353002
Cr-Commit-Position: refs/heads/master@{#36096}

[modify] https://crrev.com/369dcca7a543318194d66aaca4cb71e90bff9240/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/35e49f251f1b41703d2eb32fab2fb6044764e822

commit 35e49f251f1b41703d2eb32fab2fb6044764e822
Author: jochen <jochen@chromium.org>
Date: Tue May 10 12:30:22 2016

Rename shell to v8_shell

BUG=chromium:609107
R=machenbach@chromium.org
LOG=n

Review-Url: https://codereview.chromium.org/1962253002
Cr-Commit-Position: refs/heads/master@{#36138}

[modify] https://crrev.com/35e49f251f1b41703d2eb32fab2fb6044764e822/BUILD.gn
[modify] https://crrev.com/35e49f251f1b41703d2eb32fab2fb6044764e822/samples/samples.gyp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11513aa0e64b7be852f123c7f3dedc9be50b78ff

commit 11513aa0e64b7be852f123c7f3dedc9be50b78ff
Author: jochen <jochen@chromium.org>
Date: Wed May 11 09:59:51 2016

Use the v8 shell instead of d8 to compile jstests

BUG=609107
R=machenbach@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1953233002
Cr-Commit-Position: refs/heads/master@{#392891}

[modify] https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff/BUILD.gn
[modify] https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff/build/all.gyp
[modify] https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff/build/common.gypi
[modify] https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
[modify] https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff/chrome/chrome_tests.gypi
[modify] https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff/chrome/js_unittest_rules.gypi
[modify] https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff/chrome/test/base/js2gtest.gni

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6cb38427984f3c31ff6c8813535cfd6ebf6058c4

commit 6cb38427984f3c31ff6c8813535cfd6ebf6058c4
Author: jochen <jochen@chromium.org>
Date: Thu May 12 07:49:29 2016

Remove v8_toolset_for_d8 flag

R=machenbach@chromium.org
BUG=chromium:609107

Review-Url: https://codereview.chromium.org/1969793002
Cr-Commit-Position: refs/heads/master@{#36198}

[modify] https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4/BUILD.gn
[modify] https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4/gypfiles/toolchain.gypi
[modify] https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4/src/d8.gyp

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b33f9a6f24edef8447adcfb028b7f1d6e291c34e

commit b33f9a6f24edef8447adcfb028b7f1d6e291c34e
Author: hablich <hablich@chromium.org>
Date: Thu May 12 13:29:13 2016

Revert of Remove v8_toolset_for_d8 flag (patchset #1 id:1 of https://codereview.chromium.org/1969793002/ )

Reason for revert:
blocks roll: https://codereview.chromium.org/1975753002/

Original issue's description:
> Remove v8_toolset_for_d8 flag
>
> R=machenbach@chromium.org
> BUG=chromium:609107
>
> Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4
> Cr-Commit-Position: refs/heads/master@{#36198}

TBR=machenbach@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:609107

Review-Url: https://codereview.chromium.org/1974773002
Cr-Commit-Position: refs/heads/master@{#36209}

[modify] https://crrev.com/b33f9a6f24edef8447adcfb028b7f1d6e291c34e/BUILD.gn
[modify] https://crrev.com/b33f9a6f24edef8447adcfb028b7f1d6e291c34e/gypfiles/toolchain.gypi
[modify] https://crrev.com/b33f9a6f24edef8447adcfb028b7f1d6e291c34e/src/d8.gyp

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/df4b916e00af0949c698c20b545b0428ea0dc244

commit df4b916e00af0949c698c20b545b0428ea0dc244
Author: jochen <jochen@chromium.org>
Date: Fri May 13 14:01:07 2016

Move the dependency on "log" to v8's public config

BUG=chromium:609107
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/1973903004
Cr-Commit-Position: refs/heads/master@{#36244}

[modify] https://crrev.com/df4b916e00af0949c698c20b545b0428ea0dc244/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/baf1204df1d6d1823382fdaac7c193ce289f0031

commit baf1204df1d6d1823382fdaac7c193ce289f0031
Author: jochen <jochen@chromium.org>
Date: Fri May 13 16:11:24 2016

Reland of move v8_toolset_for_d8 flag (patchset #2 id:80001 of https://codereview.chromium.org/1974773002/ )

Reason for revert:
Addressed link failure

Original issue's description:
> Revert of Remove v8_toolset_for_d8 flag (patchset #1 id:1 of https://codereview.chromium.org/1969793002/ )
>
> Reason for revert:
> blocks roll: https://codereview.chromium.org/1975753002/
>
> Original issue's description:
> > Remove v8_toolset_for_d8 flag
> >
> > R=machenbach@chromium.org
> > BUG=chromium:609107
> >
> > Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4
> > Cr-Commit-Position: refs/heads/master@{#36198}
>
> TBR=machenbach@chromium.org,jochen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:609107
>
> Committed: https://crrev.com/b33f9a6f24edef8447adcfb028b7f1d6e291c34e
> Cr-Commit-Position: refs/heads/master@{#36209}

TBR=machenbach@chromium.org,hablich@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:609107

Review-Url: https://codereview.chromium.org/1973363002
Cr-Commit-Position: refs/heads/master@{#36250}

[modify] https://crrev.com/baf1204df1d6d1823382fdaac7c193ce289f0031/BUILD.gn
[modify] https://crrev.com/baf1204df1d6d1823382fdaac7c193ce289f0031/gypfiles/toolchain.gypi
[modify] https://crrev.com/baf1204df1d6d1823382fdaac7c193ce289f0031/src/d8.gyp

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/34fbcd70ae7c1a3eeafb82e914a2f217d72a7c9f

commit 34fbcd70ae7c1a3eeafb82e914a2f217d72a7c9f
Author: jochen <jochen@chromium.org>
Date: Mon May 30 14:31:56 2016

Move gcmole to toolchain.gypi

it's referenced from isolate.gypi which in turn is used in
non-standalone builds as well.

BUG=chromium:609107
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2023783003
Cr-Commit-Position: refs/heads/master@{#36591}

[modify] https://crrev.com/34fbcd70ae7c1a3eeafb82e914a2f217d72a7c9f/gypfiles/standalone.gypi
[modify] https://crrev.com/34fbcd70ae7c1a3eeafb82e914a2f217d72a7c9f/gypfiles/toolchain.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe

commit a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe
Author: jochen <jochen@chromium.org>
Date: Thu Jun 02 06:51:59 2016

Move (hopefully) remaining isolate related variables to toolchain.gypi

BUG=chromium:609107
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2027213002
Cr-Commit-Position: refs/heads/master@{#36664}

[modify] https://crrev.com/a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe/gypfiles/standalone.gypi
[modify] https://crrev.com/a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe/gypfiles/toolchain.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/dab67f0331c45d0379a65902215b995447d76684

commit dab67f0331c45d0379a65902215b995447d76684
Author: machenbach <machenbach@chromium.org>
Date: Thu Jun 02 07:10:20 2016

Revert of Move (hopefully) remaining isolate related variables to toolchain.gypi (patchset #1 id:1 of https://codereview.chromium.org/2027213002/ )

Reason for revert:
Fails:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7182/steps/gclient%20runhooks/logs/stdio

Original issue's description:
> Move (hopefully) remaining isolate related variables to toolchain.gypi
>
> BUG=chromium:609107
> R=machenbach@chromium.org
>
> Committed: https://crrev.com/a68a1eb38dda0a1eba3b7644a172d2f85e9c7abe
> Cr-Commit-Position: refs/heads/master@{#36664}

TBR=jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:609107

Review-Url: https://codereview.chromium.org/2038463002
Cr-Commit-Position: refs/heads/master@{#36665}

[modify] https://crrev.com/dab67f0331c45d0379a65902215b995447d76684/gypfiles/standalone.gypi
[modify] https://crrev.com/dab67f0331c45d0379a65902215b995447d76684/gypfiles/toolchain.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/5f51f767b47ddcec076ade3a76c24599d638ca16

commit 5f51f767b47ddcec076ade3a76c24599d638ca16
Author: machenbach <machenbach@chromium.org>
Date: Thu Jun 02 07:54:42 2016

V8: Explicitly define presence of valgrind on relevant builder

BUG=609107

Review-Url: https://codereview.chromium.org/2035633002

[modify] https://crrev.com/5f51f767b47ddcec076ade3a76c24599d638ca16/scripts/slave/recipe_modules/v8/builders.py
[modify] https://crrev.com/5f51f767b47ddcec076ade3a76c24599d638ca16/scripts/slave/recipe_modules/v8/chromium_config.py
[modify] https://crrev.com/5f51f767b47ddcec076ade3a76c24599d638ca16/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/09d90e4e70819607b76bdd2bd4f23be3922b9050

commit 09d90e4e70819607b76bdd2bd4f23be3922b9050
Author: jochen <jochen@chromium.org>
Date: Thu Jun 02 09:54:54 2016

Reland "Move (hopefully) remaining isolate related variables to toolchain.gypi"

BUG=chromium:609107
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2032733003
Cr-Commit-Position: refs/heads/master@{#36677}

[modify] https://crrev.com/09d90e4e70819607b76bdd2bd4f23be3922b9050/gypfiles/standalone.gypi
[modify] https://crrev.com/09d90e4e70819607b76bdd2bd4f23be3922b9050/gypfiles/toolchain.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49968784179c7a724a40c06c16d249c13c4cbad9

commit 49968784179c7a724a40c06c16d249c13c4cbad9
Author: jochen <jochen@chromium.org>
Date: Fri Jun 03 04:49:36 2016

the sanitizer builders expect d8 to be build. Make that explicit.

BUG=609107
R=machenbach@chromium.org,inferno@chromium.org

Review-Url: https://codereview.chromium.org/2018423002
Cr-Commit-Position: refs/heads/master@{#397635}

[modify] https://crrev.com/49968784179c7a724a40c06c16d249c13c4cbad9/build/all.gyp

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e4fc149dcad53be2674694e2685c4cac28a35a34

commit e4fc149dcad53be2674694e2685c4cac28a35a34
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jun 02 14:18:52 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/344b94560126de662296f89193821db2095aa8ed

commit 344b94560126de662296f89193821db2095aa8ed
Author: jochen <jochen@chromium.org>
Date: Wed Jun 22 13:36:44 2016

Add GN targets for samples

BUG=chromium:609107
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2081323004
Cr-Commit-Position: refs/heads/master@{#37187}

[modify] https://crrev.com/344b94560126de662296f89193821db2095aa8ed/BUILD.gn

We now compile all tests as part of a chromium checkout.

If we wanted, we could now write recipes to also run the v8 tests.

What is done elsewhere is to let test runners produce results that look like gtest output. Like that you can reuse parts of the chromium infrastructure, e.g. test result upload, swarming collect, how test failures are compared on tryjobs, etc. V8 has some of these features too, but it's different code and not easy to use in chromium's recipes.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot