New issue
Advanced search Search tips

Issue 609105 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Prerender: Remove MatchComplete to simplify WebContents lifetime

Project Member Reported by pasko@chromium.org, May 4 2016

Issue description

$subj.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e302bd544e4ac9ac1b119424a5b4d100340c70b

commit 3e302bd544e4ac9ac1b119424a5b4d100340c70b
Author: pasko <pasko@chromium.org>
Date: Wed May 11 16:37:56 2016

Prerender: Remove MatchComplete

This removes the control group emulation logic (i.e. "MatchComplete"), but does
not remove the MatchCompleteStatus yet - postponed for a followup change.

The problem being solved was:
1. Prerendering in the Control Group pretends that it performs prerenders as
   usual, but actually is a no-op.
2. In the Control Group there is no knowledge of cases when Prerender gives up
   early.
3. To match the FinalStatus of the Control Group the new MATCH_COMPLETE_GROUP
   was introduced. It worked as a usual prerender, and in case of giving up
   early it provided a "dummy" prerender and recorded use/no-use for the dummy
   in the lifetime.

Reasons for removing:
1. the current code probably cannot be reused for future experiments,
2. makes Prerender lifetime simpler.

BUG= 609105 

Review-Url: https://codereview.chromium.org/1896403002
Cr-Commit-Position: refs/heads/master@{#392952}

[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_handle.cc
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_handle.h
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_link_manager.cc
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_link_manager.h
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/3e302bd544e4ac9ac1b119424a5b4d100340c70b/chrome/browser/prerender/prerender_unittest.cc

Comment 3 by pasko@chromium.org, May 13 2016

Status: Fixed (was: Started)

Sign in to add a comment