New issue
Advanced search Search tips

Issue 609100 link

Starred by 2 users
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: May 2016
Cc:
timvolod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

WebViewLayoutTest are failing because of speechSynthesis

Project Member Reported by mlamouri@chromium.org, May 4 2016 
<b>Version: <Kenneth, what is the frequency?></b>
<b>OS: <please tell me it's not XP></b>

What steps will reproduce the problem?
(1)
(2)
(3)

What is the expected output?

What do you see instead?


Please use labels and text to provide additional information.

Comment 1 by mlamouri@chromium.org, May 4 2016

Summary: WebViewLayoutTest are failing because of speechSynthesis (was: Me)
C  135.071s Main  [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewExcludedInterfaces:
C  135.071s Main  junit.framework.AssertionFailedError: Interface [GLOBAL OBJECT].attribute speechSynthesis not exposed in blink
C  135.071s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewExcludedInterfaces(WebViewLayoutTest.java:149)
C  135.071s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  135.071s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  135.071s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  135.071s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  135.071s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  135.071s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  135.071s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
C  135.071s Main  
C  135.071s Main  [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces:
C  135.071s Main  junit.framework.ComparisonFailure: Missing webview interfaces found expected:<[]> but was:<[[GLOBAL OBJECT].getter speechSynthesis
C  135.071s Main  ]>
C  135.071s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:201)
C  135.071s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  135.071s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  135.071s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  135.071s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  135.071s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  135.071s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  135.071s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3168773cb69e2a78acce39d1b4c1adbf56cac87

commit e3168773cb69e2a78acce39d1b4c1adbf56cac87
Author: mlamouri <mlamouri@chromium.org>
Date: Wed May 04 14:30:38 2016

[Sheriff] Fix WebViewLayoutTest regarding global interface expectations.

The expectation file assume speechSynthesis is an attribute but its now
a getter.

BUG= 609100 
R=timvolodine@chromium.org

Review-Url: https://codereview.chromium.org/1950943002
Cr-Commit-Position: refs/heads/master@{#391504}

[modify] https://crrev.com/e3168773cb69e2a78acce39d1b4c1adbf56cac87/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Comment 4 by mlamouri@chromium.org, May 4 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4497b8860b781fa97da812edfbffa64ef27f1e4

commit a4497b8860b781fa97da812edfbffa64ef27f1e4
Author: gsennton <gsennton@chromium.org>
Date: Mon May 09 16:34:34 2016

Revert of [Sheriff] Fix WebViewLayoutTest regarding global interface expectations. (patchset #1 id:1 of https://codereview.chromium.org/1950943002/ )

Reason for revert:
Fix WebViewLayoutTest failures due to https://codereview.chromium.org/1380503002 being reverted.

Thus, to fix this we need to revert the current CL and https://codereview.chromium.org/1951253003

BUG= 609448 

Original issue's description:
> [Sheriff] Fix WebViewLayoutTest regarding global interface expectations.
>
> The expectation file assume speechSynthesis is an attribute but its now
> a getter.
>
> BUG= 609100 
> R=timvolodine@chromium.org
>
> Committed: https://crrev.com/e3168773cb69e2a78acce39d1b4c1adbf56cac87
> Cr-Commit-Position: refs/heads/master@{#391504}

TBR=timvolodine@chromium.org,mlamouri@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 609100 

Review-Url: https://codereview.chromium.org/1960923003
Cr-Commit-Position: refs/heads/master@{#392335}

[modify] https://crrev.com/a4497b8860b781fa97da812edfbffa64ef27f1e4/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
►

Sign in to add a comment