Marking the above issue as RB-Stable, Feel free to change accordingly.

Thank you!

this might be WAI --- pinged some people, we'll see what they say.

Hmm, in the past, I think pressing Esc was effectively the same as pressing the "X" in the permission bubble/prompt. Neither action in the past, as far as I recall, resulted in a "block" entry in the corresponding chrome://settings section.

If the intent really is to have pressing Esc result in a "block" entry, then I think the behavior of pressing "X" should be modified to match. And the behavior of Mac should also be modified to match.

felt@ - do you know if there are stats that track the number of times "X" is pressed in the permission bubble versus pressing Esc?

There is no tracking of ESC vs. X for permissions metrics.

Did the change to make ESC equivalent to Deny / Block is a big change for the way permissions work. Did it go through UI review? Personally I am very against the change but we should get a UX person's opinions.

I have already pinged UX people.

This change was not explicitly intentional so much as it was a consequence of bringing this bubble more in line with all the other bubbles in Chrome.

A friendly reminder that M51 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by May 17. All changes MUST be merged into the release branch by 5pm on May 20 to make into the desktop Stable final build cut. Thanks!

I have a fix here: https://codereview.chromium.org/1953943003/ I will try to land and merge it but honestly I'm not sure this is release block worthy. The behavior difference is fairly subtle.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf4ced694bba0aeb3ba518c7fe8435bc9018674

commit 0bf4ced694bba0aeb3ba518c7fe8435bc9018674
Author: estade <estade@chromium.org>
Date: Tue May 10 20:53:07 2016

In dialogs & dialog-like bubbles, make the escape button just close
the prompt.

Previously, the escape button would activate the negative button, which
was relevant if that button did anything extra in addition to closing
the prompt.

This intentionally changes the permissions bubble (back to what it
was before) as well as the bookmark bubble (now escape doesn't
remove a new bookmark). Other bubbles may be affected and
those changes are *probably* desired.

UX contacts for this decision are hwi@ and ainslie@

BUG= 609079 ,163931

Review-Url: https://codereview.chromium.org/1953943003
Cr-Commit-Position: refs/heads/master@{#392708}

[modify] https://crrev.com/0bf4ced694bba0aeb3ba518c7fe8435bc9018674/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/0bf4ced694bba0aeb3ba518c7fe8435bc9018674/chrome/browser/ui/views/ssl_client_certificate_selector.cc
[modify] https://crrev.com/0bf4ced694bba0aeb3ba518c7fe8435bc9018674/chrome/browser/ui/views/ssl_client_certificate_selector.h
[modify] https://crrev.com/0bf4ced694bba0aeb3ba518c7fe8435bc9018674/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
[modify] https://crrev.com/0bf4ced694bba0aeb3ba518c7fe8435bc9018674/ui/views/window/dialog_client_view.cc
[modify] https://crrev.com/0bf4ced694bba0aeb3ba518c7fe8435bc9018674/ui/views/window/dialog_delegate_unittest.cc

I plan to let this bake a little bit before asking for a merge.

Verified in M52 Canary 52.0.2734.0 in Win, Mac, Linux

After clearing mic/camera permissions in chrome://settings/content, and pressing 'Esc' button in the permission bubble while at https://test.webrtc.org/manual/audio-and-video/, 'block' action is not activated and the permission bubble just closes
(equivalent to pressing the 'x' in the same permission bubble)

Just to update:

Rechecked above issue in latest canary version 52.0.2734.0,it seems to be fixed and working as intended.kindly refer the attached video for the same.

Thank you

Deleted: Actual_Fix.mp4 478 KB

Actual_Fix.mp4 478 KB Download

Your change meets the bar and is auto-approved for M51 (branch: 2704)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/567f799de8d6228d905c2d10d7db9fe0f4e81223

commit 567f799de8d6228d905c2d10d7db9fe0f4e81223
Author: Evan Stade <estade@chromium.org>
Date: Fri May 13 16:43:36 2016

In dialogs & dialog-like bubbles, make the escape button just close the prompt.

Previously, the escape button would activate the negative button, which
was relevant if that button did anything extra in addition to closing
the prompt.

This intentionally changes the permissions bubble (back to what it
was before) as well as the bookmark bubble (now escape doesn't
remove a new bookmark). Other bubbles may be affected and
those changes are *probably* desired.

UX contacts for this decision are hwi@ and ainslie@

BUG= 609079 ,163931

Review-Url: https://codereview.chromium.org/1953943003
Cr-Commit-Position: refs/heads/master@{#392708}
(cherry picked from commit 0bf4ced694bba0aeb3ba518c7fe8435bc9018674)

Review URL: https://codereview.chromium.org/1978883002 .

Cr-Commit-Position: refs/branch-heads/2704@{#537}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/567f799de8d6228d905c2d10d7db9fe0f4e81223/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/567f799de8d6228d905c2d10d7db9fe0f4e81223/chrome/browser/ui/views/ssl_client_certificate_selector.cc
[modify] https://crrev.com/567f799de8d6228d905c2d10d7db9fe0f4e81223/chrome/browser/ui/views/ssl_client_certificate_selector.h
[modify] https://crrev.com/567f799de8d6228d905c2d10d7db9fe0f4e81223/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
[modify] https://crrev.com/567f799de8d6228d905c2d10d7db9fe0f4e81223/ui/views/window/dialog_client_view.cc
[modify] https://crrev.com/567f799de8d6228d905c2d10d7db9fe0f4e81223/ui/views/window/dialog_delegate_unittest.cc

Tested the same on win7, Linux 14.04 chrome version 51.0.2704.54 - Chrome did not 'Block' for microphone after pressing 'Esc' key.

Please find the screenshot

Fix works as expected

Deleted: Screenshot from 2016-05-18 12:02:30.png 156 KB

	Screenshot from 2016-05-18 12:02:30.png 156 KB View Download

Verified in M51 Beta 51.0.2704.54 in Win, Mac, Linux

After clearing mic/camera permissions in chrome://settings/content, and pressing 'Esc' button in the permission bubble while at https://test.webrtc.org/manual/audio-and-video/, 'block' action is not activated and the permission bubble just closes
(equivalent to pressing the 'x' in the same permission bubble)

 Issue 920639  has been merged into this issue.