Need implementation for characteristic scanning.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6af3e124c3e3745f280d3b0c5c9491a5e603340f commit 6af3e124c3e3745f280d3b0c5c9491a5e603340f Author: jlebel <jlebel@chromium.org> Date: Thu Jun 16 10:51:04 2016 bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. BUG= 609064 Review-Url: https://codereview.chromium.org/1950033002 Cr-Commit-Position: refs/heads/master@{#400127} [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/BUILD.gn [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/BUILD.gn [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth.gyp [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_low_energy_device_mac.h [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_low_energy_device_mac.mm [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm [add] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h [add] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_remote_gatt_service_mac.h [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_remote_gatt_service_mac.mm [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/bluetooth_test_mac.h [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/bluetooth_test_mac.mm [add] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h [add] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/mock_bluetooth_cbservice_mac.h [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/bluetooth/test/mock_bluetooth_cbservice_mac.mm [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/device/device_tests.gyp [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3 commit 4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3 Author: grunell <grunell@chromium.org> Date: Thu Jun 16 13:48:04 2016 Revert of bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation (patchset #14 id:260001 of https://codereview.chromium.org/1950033002/ ) Reason for revert: Breaks Mac compile: https://build.chromium.org/p/chromium/builders/Mac/builds/16785 Original issue's description: > bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation > > Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. > > Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. > > BUG= 609064 > > Committed: https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f > Cr-Commit-Position: refs/heads/master@{#400127} TBR=ortuno@chromium.org,fbeaufort@chromium.org,msarda@chromium.org,scheib@chromium.org,jlebel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 609064 Review-Url: https://codereview.chromium.org/2071853002 Cr-Commit-Position: refs/heads/master@{#400143} [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/BUILD.gn [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/BUILD.gn [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth.gyp [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth_low_energy_device_mac.h [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth_low_energy_device_mac.mm [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm [delete] https://crrev.com/2bfe70488ff22678385081733bf93e114847fbaa/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h [delete] https://crrev.com/2bfe70488ff22678385081733bf93e114847fbaa/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth_remote_gatt_service_mac.h [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth_remote_gatt_service_mac.mm [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/test/bluetooth_test_mac.h [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/test/bluetooth_test_mac.mm [delete] https://crrev.com/2bfe70488ff22678385081733bf93e114847fbaa/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h [delete] https://crrev.com/2bfe70488ff22678385081733bf93e114847fbaa/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/test/mock_bluetooth_cbservice_mac.h [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/bluetooth/test/mock_bluetooth_cbservice_mac.mm [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/device/device_tests.gyp [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/4dfb0cd00934f1564b63f4510d1c8a7c6e4f0ac3/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/027333819f3fb880a7e433157dfc4c55d3bf8268 commit 027333819f3fb880a7e433157dfc4c55d3bf8268 Author: jlebel <jlebel@chromium.org> Date: Thu Jun 16 21:41:15 2016 bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. BUG= 609064 Committed: https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f Review-Url: https://codereview.chromium.org/1950033002 Cr-Original-Commit-Position: refs/heads/master@{#400127} Cr-Commit-Position: refs/heads/master@{#400266} [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/BUILD.gn [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/BUILD.gn [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth.gyp [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_low_energy_device_mac.h [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_low_energy_device_mac.mm [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm [add] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h [add] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_remote_gatt_service_mac.h [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_remote_gatt_service_mac.mm [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/bluetooth_test_mac.h [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/bluetooth_test_mac.mm [add] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h [add] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/mock_bluetooth_cbservice_mac.h [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/bluetooth/test/mock_bluetooth_cbservice_mac.mm [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/device/device_tests.gyp [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/158fd7ff3a856250c253e92a469b00cf3852b113 commit 158fd7ff3a856250c253e92a469b00cf3852b113 Author: ortuno <ortuno@chromium.org> Date: Fri Jun 17 00:34:07 2016 Revert of bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation (patchset #15 id:280001 of https://codereview.chromium.org/1950033002/ ) Reason for revert: Breaks mac bot: https://bugs.chromium.org/p/chromium/issues/detail?id=620917#c1 Original issue's description: > bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation > > Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. > > Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. > > BUG= 609064 > > Committed: https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f > Committed: https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268 > Cr-Original-Commit-Position: refs/heads/master@{#400127} > Cr-Commit-Position: refs/heads/master@{#400266} TBR=fbeaufort@chromium.org,msarda@chromium.org,scheib@chromium.org,jlebel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 609064 Review-Url: https://codereview.chromium.org/2078773002 Cr-Commit-Position: refs/heads/master@{#400314} [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/BUILD.gn [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/BUILD.gn [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth.gyp [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth_low_energy_device_mac.h [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth_low_energy_device_mac.mm [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm [delete] https://crrev.com/70efd3c21df765a6aa56c40581e5c64620e2ce87/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h [delete] https://crrev.com/70efd3c21df765a6aa56c40581e5c64620e2ce87/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth_remote_gatt_service_mac.h [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth_remote_gatt_service_mac.mm [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/test/bluetooth_test_mac.h [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/test/bluetooth_test_mac.mm [delete] https://crrev.com/70efd3c21df765a6aa56c40581e5c64620e2ce87/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h [delete] https://crrev.com/70efd3c21df765a6aa56c40581e5c64620e2ce87/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/test/mock_bluetooth_cbservice_mac.h [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/bluetooth/test/mock_bluetooth_cbservice_mac.mm [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/device/device_tests.gyp [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/620327dbe7be34248528cde2425ea979f90ca8b6 commit 620327dbe7be34248528cde2425ea979f90ca8b6 Author: jlebel <jlebel@chromium.org> Date: Mon Jun 20 13:01:00 2016 bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation Fix for: https://codereview.chromium.org/1950033002/ Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. BUG= 609064 Review-Url: https://codereview.chromium.org/2071323002 Cr-Commit-Position: refs/heads/master@{#400663} [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/BUILD.gn [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/BUILD.gn [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth.gyp [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_low_energy_device_mac.h [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_low_energy_device_mac.mm [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm [add] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h [add] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_remote_gatt_service_mac.h [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_remote_gatt_service_mac.mm [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/bluetooth_test_mac.h [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/bluetooth_test_mac.mm [add] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h [add] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/mock_bluetooth_cbservice_mac.h [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/bluetooth/test/mock_bluetooth_cbservice_mac.mm [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/device/device_tests.gyp [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/620327dbe7be34248528cde2425ea979f90ca8b6/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by jlebel@chromium.org
, May 4 2016Blocking: 364359
Status: Available (was: Untriaged)