New issue
Advanced search Search tips

Issue 609050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Auto signin first run experience dialog should be modal.

Project Member Reported by melandory@chromium.org, May 4 2016

Issue description


Make dialog modal.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7507feb7fc4bc05bf375455f204ff10a753b0d

commit 3f7507feb7fc4bc05bf375455f204ff10a753b0d
Author: melandory <melandory@chromium.org>
Date: Wed May 04 10:43:27 2016

[Smart Lock] Make Auto-signin first run experience dialog modal.

BUG= 609050 

Review-Url: https://codereview.chromium.org/1946163002
Cr-Commit-Position: refs/heads/master@{#391473}

[modify] https://crrev.com/3f7507feb7fc4bc05bf375455f204ff10a753b0d/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java

Labels: Merge-Request-51

Comment 3 by tin...@google.com, May 4 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f4bfc41509a3f36f7d9e1f8474e292fc5f7677

commit 07f4bfc41509a3f36f7d9e1f8474e292fc5f7677
Author: Tatiana Gornak <melandory@chromium.org>
Date: Wed May 04 13:12:02 2016

[Smart Lock] Make Auto-signin first run experience dialog modal.

BUG= 609050 

Review-Url: https://codereview.chromium.org/1946163002
Cr-Commit-Position: refs/heads/master@{#391473}
(cherry picked from commit 3f7507feb7fc4bc05bf375455f204ff10a753b0d)

Review URL: https://codereview.chromium.org/1949063002 .

Cr-Commit-Position: refs/branch-heads/2704@{#371}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/07f4bfc41509a3f36f7d9e1f8474e292fc5f7677/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java

Status: Fixed (was: Started)

Sign in to add a comment