New issue
Advanced search Search tips

Issue 609040 link

Starred by 2 users
Status: Fixed
Owner:
melandory@chromium.org
Closed: May 2016
Cc:
sabineb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Clicking "ok, got it" on autosign-in turns off the autosignin.

Project Member Reported by melandory@chromium.org, May 4 2016 

Clicking on "Ok got it" in the auto sign-in first-run on Clank does turn off the auto sign-in setting now. Was this regression maybe introduced with your fix for treating the "Turn off" button properly?
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/329172ed54f5cf319076fc82d0c46bc2b1f43731

commit 329172ed54f5cf319076fc82d0c46bc2b1f43731
Author: melandory <melandory@chromium.org>
Date: Wed May 04 09:55:42 2016

[Smart Lock] Fix "ok, got it" button behavour.

BUG= 609040 

Review-Url: https://codereview.chromium.org/1945093003
Cr-Commit-Position: refs/heads/master@{#391469}

[modify] https://crrev.com/329172ed54f5cf319076fc82d0c46bc2b1f43731/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java

Comment 2 by melandory@chromium.org, May 4 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, May 4 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ad9bbf83ec4f9288789d2dc78cae4fefea55235

commit 0ad9bbf83ec4f9288789d2dc78cae4fefea55235
Author: Tatiana Gornak <melandory@chromium.org>
Date: Wed May 04 13:04:17 2016

[Smart Lock] Fix "ok, got it" button behavour.

BUG= 609040 

Review-Url: https://codereview.chromium.org/1945093003
Cr-Commit-Position: refs/heads/master@{#391469}
(cherry picked from commit 329172ed54f5cf319076fc82d0c46bc2b1f43731)

Review URL: https://codereview.chromium.org/1951563003 .

Cr-Commit-Position: refs/branch-heads/2704@{#370}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/0ad9bbf83ec4f9288789d2dc78cae4fefea55235/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java

Comment 5 by melandory@chromium.org, May 4 2016

Status: Fixed (was: Started)

Comment 6 by melandory@chromium.org, May 4 2016 

Issue 609237 has been merged into this issue.
►

Sign in to add a comment