New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609026 link

Starred by 3 users

Issue metadata

Status: Duplicate
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 505805



Sign in to add a comment

Immersive mode for MD tabstrip

Project Member Reported by pkasting@chromium.org, May 4 2016

Issue description

I haven't looked at immersive mode at all.  I think Tab::GetImmersiveBarRect() likely needs updating, though I need to understand how immersive tab rects should correspond with non-immersive tab bounds (it's not necessarily clear to me whether the X-coords should match 1:1).
 
Cc: tdander...@chromium.org
Peter, can you confirm if this is actually applicable to Windows/Linux? As I understand it, immersive mode is an Ash-only feature, and we plan to remove the lightbars corresponding to the tabs (see issue 607029).
Cc: sky@chromium.org
Not sure.  There's code in the codebase for immersive-related stuff on Mac, it looks like, and I didn't think the tabstrip code bits were Ash-gated.  Scott, do you know the story on immersive mode?
Components: UI>Browser>TabStrip
Owner: tdander...@chromium.org
Status: Assigned (was: Unconfirmed)
Labels: -OS-Linux -OS-Windows
Mergedinto: 607029
Status: Duplicate (was: Assigned)
Clicking the "fullscreen" icon in the Chrome menu does different things on different platforms:

Win/Linux: current tab becomes fullscreen (user must press F11 to exit fullscreen).

ChromeOS: immersive mode is entered. The tabs shrink to narrow horizontal bars, and hovering the mouse near the top of the screen makes the top chrome slide into view.

OSX: the Chrome browser window appears maximized (tabstrip is still fully visible) and the system menu (File, Edit, etc) becomes hidden. Moving the mouse to the top of the screen makes the system menu appear.

Given that this is ChromeOS-specific, and the plan of record is to stop showing the immersive mode version of the tabstrip (narrow bars), I'm merging this into issue 607029. 

Sign in to add a comment