Issue metadata
Sign in to add a comment
|
Regression: Urls of synced history doesn't open in newtab on using mid click |
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2724.0 dev OS: Ubunut 12.04,14.04,windows What steps will reproduce the problem? (1) Sign in to chrome so that synced history is seen in chrome://history (2) Now midclick using mouse wheel on any of the url in synced history and observe Expected: On using midclick url should be opened in new tab. Actual: Instead nothing happens on using midclick. Note: 1.This works fine with normal history[which is not synced] 2. Double clicking opens urls in new tab.[Both synced and non-synced] This is a regression issue broken in M52. Good Build: 52.0.2718.0 dev Bad Build: 52.0.2719.0 dev Unable to tool bisect as we can't sign in to chromium builds to check synced history. Hence providing manual changelog Cr: https://chromium.googlesource.com/chromium/src/+log/52.0.2718.0..52.0.2719.0?pretty=fuller&n=10000 Suspecting https://codereview.chromium.org/1894253002 from changelog @nzolghadr: Please help in re-assigning if it is not related to your change.
,
May 4 2016
,
May 13 2016
just to update, able to reproduce the issue on Win7, Ubuntu 14.04 using Chrome # 52.0.2735.0 nzolghadr@ could you please check and update.
,
May 13 2016
There is a similar issue in new tap page and I was just waiting that CL to land and hopefully share the same logic for this CL as well.
,
May 13 2016
,
May 19 2016
Just to update: Able to reproduce the issue on win8.1 using chrome version canary 52.0.2741.0
,
May 24 2016
Still able to reproduce the issue on Windows 7, Ubuntu 14.04 using 52.0.2743.3.
,
May 31 2016
Just to update. Still able to repro this issue on Windows 7 using the Chrome Canary Version - 53.0.2751.0
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a154aed1a3813cf28c6f477579ed7974a2528570 commit a154aed1a3813cf28c6f477579ed7974a2528570 Author: nzolghadr <nzolghadr@chromium.org> Date: Thu Jun 02 21:37:13 2016 Fix history page middle click action Send synthetic middle click in history page and also prevent default it as the links in history page will trigger twice if we don't prevent default it. BUG= 609020 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2018943003 Cr-Commit-Position: refs/heads/master@{#397512} [modify] https://crrev.com/a154aed1a3813cf28c6f477579ed7974a2528570/chrome/browser/resources/history/history.js [modify] https://crrev.com/a154aed1a3813cf28c6f477579ed7974a2528570/chrome/browser/resources/ntp4/new_tab.html [rename] https://crrev.com/a154aed1a3813cf28c6f477579ed7974a2528570/chrome/browser/resources/synthetic_middleclick.js
,
Jun 6 2016
,
Jun 6 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20cd211911527a6aa2c20486738a9870a0b40824 commit 20cd211911527a6aa2c20486738a9870a0b40824 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Jun 06 18:31:02 2016 Fix history page middle click action Send synthetic middle click in history page and also prevent default it as the links in history page will trigger twice if we don't prevent default it. BUG= 609020 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2018943003 Cr-Commit-Position: refs/heads/master@{#397512} (cherry picked from commit a154aed1a3813cf28c6f477579ed7974a2528570) Review URL: https://codereview.chromium.org/2040813003 . Cr-Commit-Position: refs/branch-heads/2743@{#242} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/20cd211911527a6aa2c20486738a9870a0b40824/chrome/browser/resources/history/history.js [modify] https://crrev.com/20cd211911527a6aa2c20486738a9870a0b40824/chrome/browser/resources/ntp4/new_tab.html [rename] https://crrev.com/20cd211911527a6aa2c20486738a9870a0b40824/chrome/browser/resources/synthetic_middleclick.js
,
Jun 8 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 using chrome version 52.0.2743.33.able to open the synced URLs with mouse middle click. Please find the attached screen cast for the same. Adding TE-Verified label. Thanks,
,
Jun 8 2016
,
Jun 21 2016
,
Sep 8 2016
The "click" event is no longer dispatched for non-primary buttons as per UI events spec. This will ensure the pages that don't check the buttons attribute on their click handlers don't show unexpected behaviors when middle clicking for example. Instead there will be new event "auxclick" event for non-primary buttons that will be useful for some apps that truly care about click action for non-primary buttons. For example in case someone wants to prevent opening a new tab when middle clicking a link or adobt any other actions on click behavior of any non-primary button. Here is the spec for the event and some examples: https://navidz.github.io/auxclick/
,
Oct 5 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by durga.behera@chromium.org
, May 4 2016