New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609018 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Trace of blue highlight is seen on checkbox in chrome://plugins.

Reported by vvishwak...@etouch.net, May 4 2016

Issue description

Version: 52.0.2724.0 (Official Build) 76d17b826d6473ef7a4bb731aa8b8dc05aaa5ab6-refs/heads/master@{#391399} (32/64-bit)
OS: Linux (Ubuntu 14.04 LTS), Windows (7,8,8.1,10)

What steps will reproduce the problem?
1) Launch chrome and go to 'chrome://plugins'.
2) Press Tab key till focus is on 'Always allowed to run' checkbox for second plugin.
3) Again press Tab key and observe the checkbox.

Trace of blue highlight is seen on checkbox.

No such trace should be seen on checkbox.

This is a Regression issue broken in M-52, below is the bisect info
Manual bisect:
Good build: 52.0.2712.0 
Bad build: 52.0.2713.0 

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/8793c4ac3ab093d2cc73624dfc4828e0a58be6b7..f7ffad51fe92305e463f4af147f67a04f8b5b1a0?pretty=fuller&n=10000

Suspecting: r388281

Note: Issue is not seen on Mac OS.

 
plugins_actual.mp4
461 KB Download
plugins_expected.mp4
418 KB Download
Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this is a recent regression.

Feel free to change accordingly.

Thank you!
Components: -Internals>Plugins Blink>Layout Blink>Paint
Owner: robho...@gmail.com
Bisects to this change by robhogan:

https://chromium.googlesource.com/chromium/src/+/dd58ba2e0a29385319e2b1fd351a77b04886b591
Status: Started (was: Assigned)
Just to update the bug, Issue is still observed on Windows 7 using chrome latest canary M52-52.0.2730.0.
still able to reproduce the issue on windows 7 using chrome latest canary version 52.0.2738.0.

robhogan@ Please update on this issue.

Thanks,
Cc: tkonch...@chromium.org
Just to update:

This issue is still seen on win8.1 latest chrome canary 52.0.2741.0 

robhogan@ Would you mind providing an update on this.
CL in progress!
Project Member

Comment 8 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/806f45bd9dd5e39cdc20009f2b03bfa9d24566e0

commit 806f45bd9dd5e39cdc20009f2b03bfa9d24566e0
Author: robhogan <robhogan@gmail.com>
Date: Thu May 19 21:28:12 2016

Avoid overflow recalc on tables if sections need rebuild

A second go at https://codereview.chromium.org/1901203002. What I really should
have done in that CL is return early if the table sections needed rebuilding.
There are legitimate cases where a table needs layout but may not need to layout
its sections.

BUG= 609018 

Review-Url: https://codereview.chromium.org/1946413002
Cr-Commit-Position: refs/heads/master@{#394871}

[modify] https://crrev.com/806f45bd9dd5e39cdc20009f2b03bfa9d24566e0/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/806f45bd9dd5e39cdc20009f2b03bfa9d24566e0/third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp

Comment 9 by ajha@chromium.org, May 20 2016

Labels: TE-Verified-M52 TE-Verified-52.0.2743.0
This is working as intended on Window-7 and Linux Ubuntu 14.04 on the latest M-52(52.0.2743.0). Hence adding the verified labels.
Cc: rnimmagadda@chromium.org
@robhogan: Could you please change the Status of this issue. Since it is already verified as per the comment #9

Also, issue is not found on Canary Version - 52.0.2751.0
Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-52; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-52 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
No merge required.

Sign in to add a comment