New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609012 link

Starred by 1 user
Status: Fixed
Owner:
█ kochi@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
mahmadi@chromium.org
█ sigbjo...@opera.com
█ brajkumar@chromium.org
dbeam@chromium.org
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Assertion failed: !current || !isNonFocusableShadowHost(*current)

Project Member Reported by michae...@chromium.org, May 4 2016 
Seeing this in my local Chrome-on-Chrome-OS build (52.0.2724.0)

Doesn't repro on other builds, may be related to "remove_webcore_debug_symbols=1" or maybe just a bad build?

1. Visit chrome://md-settings
2. Click juuuust below one of the section titles (People, Appearance, etc.)

ASSERTION FAILED: !current || !isNonFocusableShadowHost(*current)
../../third_party/WebKit/Source/core/page/FocusController.cpp(649) : blink::Element *blink::(anonymous namespace)::findFocusableElementAcrossFocusScopesForward(blink::(anonymous namespace)::ScopedFocusNavigation &)
1   0x7f01097c170b blink::FocusController::advanceFocusInDocumentOrder(blink::LocalFrame*, blink::Element*, blink::WebFocusType, bool, blink::InputDeviceCapabilities*)
2   0x7f01097c144c blink::FocusController::advanceFocus(blink::WebFocusType, bool, blink::InputDeviceCapabilities*)
3   0x7f01099eb0c6 blink::EventHandler::defaultTabEventHandler(blink::KeyboardEvent*)
4   0x7f01099eab7c blink::EventHandler::defaultKeyboardEventHandler(blink::KeyboardEvent*)
5   0x7f01099c33a1
6   0x7f01099c2d3e
7   0x7f01099c24f2
8   0x7f01099ea797 blink::EventHandler::keyEvent(blink::PlatformKeyboardEvent const&)
9   0x7f0113e10e85 blink::WebViewImpl::handleKeyEvent(blink::WebKeyboardEvent const&)
10  0x7f0113e0fe04 blink::WebViewImpl::handleInputEvent(blink::WebInputEvent const&)
11  0x7f0112894dbf content::RenderWidgetInputHandler::HandleInputEvent(blink::WebInputEvent const&, ui::LatencyInfo const&, content::InputEventDispatchType)
12  0x7f011291dd48
13  0x7f011291d4ff content::RenderWidget::OnMessageReceived(IPC::Message const&)
14  0x7f011290b20e content::RenderViewImpl::OnMessageReceived(IPC::Message const&)
15  0x7f01112b1288 IPC::MessageRouter::RouteMessage(IPC::Message const&)
16  0x7f01112b11e9 IPC::MessageRouter::OnMessageReceived(IPC::Message const&)
17  0x7f0112714a98 content::ChildThreadImpl::OnMessageReceived(IPC::Message const&)
18  0x7f0112337922
19  0x7f0112392268
20  0x7f01146975d6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
21  0x7f01087008e1 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(scheduler::internal::WorkQueue*, scheduler::internal::TaskQueueImpl::Task*)
22  0x7f01086ff675 scheduler::TaskQueueManager::DoWork(base::TimeTicks, bool)
23  0x7f0108701814
24  0x7f01146975d6 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
25  0x7f01146bc585 base::MessageLoop::RunTask(base::PendingTask const&)
26  0x7f01146bc8b8 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)
27  0x7f01146bcc3b base::MessageLoop::DoWork()
28  0x7f01146be39d base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
29  0x7f01146bc121 base::MessageLoop::RunHandler()
30  0x7f01146e14d0 base::RunLoop::Run()
31  0x7f01146bb420 base::MessageLoop::Run()
Received signal 11 SEGV_MAPERR 0000fbadbeef
#0 0x7f01146962c7 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f010b9db340 <unknown>
#2 0x7f01097c21ae blink::(anonymous namespace)::findFocusableElementAcrossFocusScopes()
#3 0x7f01097c170b blink::FocusController::advanceFocusInDocumentOrder()
#4 0x7f01097c144c blink::FocusController::advanceFocus()
#5 0x7f01099eb0c6 blink::EventHandler::defaultTabEventHandler()
#6 0x7f01099eab7c blink::EventHandler::defaultKeyboardEventHandler()
#7 0x7f01099c33a1 blink::EventDispatcher::dispatchEventPostProcess()
#8 0x7f01099c2d3e blink::EventDispatcher::dispatch()
#9 0x7f01099c24f2 blink::EventDispatcher::dispatchEvent()
#10 0x7f01099ea797 blink::EventHandler::keyEvent()
#11 0x7f0113e10e85 blink::WebViewImpl::handleKeyEvent()
#12 0x7f0113e0fe04 blink::WebViewImpl::handleInputEvent()
#13 0x7f0112894dbf content::RenderWidgetInputHandler::HandleInputEvent()
#14 0x7f011291dd48 _ZN3IPC8MessageTI30InputMsg_HandleInputEvent_MetaSt5tupleIJPKN5blink13WebInputEventEN2ui11LatencyInfoEN7content22InputEventDispatchTypeEEEvE8DispatchINS9_12RenderWidgetESE_vMSE_FvS6_RKS8_SA_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#15 0x7f011291d4ff content::RenderWidget::OnMessageReceived()
#16 0x7f011290b20e content::RenderViewImpl::OnMessageReceived()
#17 0x7f01112b1288 IPC::MessageRouter::RouteMessage()
#18 0x7f01112b11e9 IPC::MessageRouter::OnMessageReceived()
#19 0x7f0112714a98 content::ChildThreadImpl::OnMessageReceived()
#20 0x7f0112337922 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content21AppCacheURLRequestJobEFvRKNS6_25AppCacheExecutableHandler8ResponseEEEEFvPS7_SB_EJNS_7WeakPtrIS7_EEEEENS0_12InvokeHelperILb1EvSE_EEFvSB_EE3RunEPNS0_13BindStateBaseESB_
#21 0x7f0112392268 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS_8CallbackIFvRKSt6vectorIN7content21CacheStorageUsageInfoESaIS8_EEELNS0_8CopyModeE1EEESD_JSA_EEENS0_12InvokeHelperILb0EvSF_EEFvvEE3RunEPNS0_13BindStateBaseE
#22 0x7f01146975d6 base::debug::TaskAnnotator::RunTask()
#23 0x7f01087008e1 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#24 0x7f01086ff675 scheduler::TaskQueueManager::DoWork()
#25 0x7f0108701814 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#26 0x7f01146975d6 base::debug::TaskAnnotator::RunTask()
#27 0x7f01146bc585 base::MessageLoop::RunTask()
#28 0x7f01146bc8b8 base::MessageLoop::DeferOrRunPendingTask()
#29 0x7f01146bcc3b base::MessageLoop::DoWork()
#30 0x7f01146be39d base::MessagePumpDefault::Run()
#31 0x7f01146bc121 base::MessageLoop::RunHandler()
#32 0x7f01146e14d0 base::RunLoop::Run()
#33 0x7f01146bb420 base::MessageLoop::Run()
#34 0x7f011292bf07 content::RendererMain()
#35 0x7f01122cc89b content::RunZygote()
#36 0x7f01122cd7c1 content::ContentMainRunnerImpl::Run()
#37 0x7f01122cc4a0 content::ContentMain()
#38 0x7f01152a78db ChromeMain
#39 0x7f010b627ec5 __libc_start_main
#40 0x7f01152a778f <unknown>
  r8: 00007f0104ed0900  r9: 0000000000000009 r10: 00007f010b9c2be0 r11: 0000000000000000
 r12: 00001ac47e3c24d0 r13: 00003a80e5da1e50 r14: 00000000fbadbeef r15: 000039c10d1ccc30
  di: 00002e3df90e9068  si: 00002e3df96863c0  bp: 000039c10d1ccc30  bx: 00007ffe8d4f2150
  dx: 0000000000000686  ax: 00000000000017dc  cx: 0000000000000824  sp: 00007ffe8d4f1f60
  ip: 00007f01097c21ae efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000006
 trp: 000000000000000e msk: 0000000000000000 cr2: 00000000fbadbeef
[end of stack trace]




What steps will reproduce the problem?
(1)
(2)
(3)

What is the expected output?

What do you see instead?


Please use labels and text to provide additional information.

Comment 1 by michae...@chromium.org, May 4 2016

Cc: dbeam@chromium.org mahmadi@chromium.org
Labels: -Pri-2 Stability-Crash Pri-1

Comment 2 by michae...@chromium.org, May 4 2016

Owner: hayato@chromium.org
Repros on Linux as well, dunno about other platforms. Doesn't seem related to any particular gyp define.

Comment 3 by mahmadi@chromium.org, May 4 2016 

Can see this on my local linux build as well (52.0.2725.0)

1. Enable chrome://flags/#enable-material-design-user-manager
1. Visit chrome://md-user-manager
2. Click 'ADD PERSON' at the bottom of the page. Once taken to the next page, before clicking anywhere on the page, press 'Tab'.

ASSERTION FAILED: !current || !isNonFocusableShadowHost(*current)
../../third_party/WebKit/Source/core/page/FocusController.cpp(649) : blink::Element *blink::(anonymous namespace)::findFocusableElementAcrossFocusScopesForward(blink::(anonymous namespace)::ScopedFocusNavigation &)
1   0x7f75eb2f5c93
2   0x7f75eb2f4292
3   0x7f75eb2f37ac blink::FocusController::advanceFocusInDocumentOrder(blink::LocalFrame*, blink::Element*, blink::WebFocusType, bool, blink::InputDeviceCapabilities*)
4   0x7f75eb2f353d blink::FocusController::advanceFocus(blink::WebFocusType, bool, blink::InputDeviceCapabilities*)
5   0x7f75eb6746d7
6   0x7f75eb671e03 blink::EventHandler::defaultTabEventHandler(blink::KeyboardEvent*)
7   0x7f75eb671b0d blink::EventHandler::defaultKeyboardEventHandler(blink::KeyboardEvent*)
8   0x7f75eb56a76d blink::Node::defaultEventHandler(blink::Event*)
9   0x7f75eb7dfe2f blink::HTMLElement::defaultEventHandler(blink::Event*)
10  0x7f75eb630cb7
11  0x7f75eb62fd59
12  0x7f75eb62f0e5
13  0x7f75eb62f309
14  0x7f75eb56a194 blink::Node::dispatchEventInternal(blink::Event*)
15  0x7f75eb6452bc blink::EventTarget::dispatchEvent(blink::Event*)
16  0x7f75eb67169f blink::EventHandler::keyEvent(blink::PlatformKeyboardEvent const&)
17  0x7f760068d25f blink::WebViewImpl::handleKeyEvent(blink::WebKeyboardEvent const&)
18  0x7f76005acdfe
19  0x7f760068bf19 blink::WebViewImpl::handleInputEvent(blink::WebInputEvent const&)
20  0x7f75fd3157f4 content::RenderWidgetInputHandler::HandleInputEvent(blink::WebInputEvent const&, ui::LatencyInfo const&, content::InputEventDispatchType)
21  0x7f75fd485f70 content::RenderWidget::OnHandleInputEvent(blink::WebInputEvent const*, ui::LatencyInfo const&, content::InputEventDispatchType)
22  0x7f75fd2fa9ad
23  0x7f75fd4957b5
24  0x7f75fd49575f
25  0x7f75fd48ebf9
26  0x7f75fd484f66 content::RenderWidget::OnMessageReceived(IPC::Message const&)
27  0x7f75fd458e9b content::RenderViewImpl::OnMessageReceived(IPC::Message const&)
28  0x7f75f9fb9c8b IPC::MessageRouter::RouteMessage(IPC::Message const&)
29  0x7f75fceddc98 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage(IPC::Message const&)
30  0x7f75f9fb9c0e IPC::MessageRouter::OnMessageReceived(IPC::Message const&)
31  0x7f75fcee12c4 content::ChildThreadImpl::OnMessageReceived(IPC::Message const&)
Received signal 11 SEGV_MAPERR 0000fbadbeef
#0 0x7f7601772dfe base::debug::StackTrace::StackTrace()
#1 0x7f760177293f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f75f2c8f340 <unknown>
#3 0x7f75eb2f5c9a blink::(anonymous namespace)::findFocusableElementAcrossFocusScopesForward()
#4 0x7f75eb2f4292 blink::(anonymous namespace)::findFocusableElementAcrossFocusScopes()
#5 0x7f75eb2f37ac blink::FocusController::advanceFocusInDocumentOrder()
#6 0x7f75eb2f353d blink::FocusController::advanceFocus()
#7 0x7f75eb6746d7 blink::FocusController::advanceFocus()
#8 0x7f75eb671e03 blink::EventHandler::defaultTabEventHandler()
#9 0x7f75eb671b0d blink::EventHandler::defaultKeyboardEventHandler()
#10 0x7f75eb56a76d blink::Node::defaultEventHandler()
#11 0x7f75eb7dfe2f blink::HTMLElement::defaultEventHandler()
#12 0x7f75eb630cb7 blink::EventDispatcher::dispatchEventPostProcess()
#13 0x7f75eb62fd59 blink::EventDispatcher::dispatch()
#14 0x7f75eb62f0e5 blink::EventDispatchMediator::dispatchEvent()
#15 0x7f75eb62f309 blink::EventDispatcher::dispatchEvent()
#16 0x7f75eb56a194 blink::Node::dispatchEventInternal()
#17 0x7f75eb6452bc blink::EventTarget::dispatchEvent()
#18 0x7f75eb67169f blink::EventHandler::keyEvent()
#19 0x7f760068d25f blink::WebViewImpl::handleKeyEvent()
#20 0x7f76005acdfe blink::PageWidgetDelegate::handleInputEvent()
#21 0x7f760068bf19 blink::WebViewImpl::handleInputEvent()
#22 0x7f75fd3157f4 content::RenderWidgetInputHandler::HandleInputEvent()
#23 0x7f75fd485f70 content::RenderWidget::OnHandleInputEvent()
#24 0x7f75fd2fa9ad _ZN4base20DispatchToMethodImplIPN7content16IdleUserDetectorEMS2_FvPKN5blink13WebInputEventERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEEJS7_S9_SC_EJLm0ELm1ELm2EEEEvRKT_T0_RKSt5tupleIJDpT1_EENS_13IndexSequenceIJXspT2_EEEE
#25 0x7f75fd4957b5 _ZN4base16DispatchToMethodIPN7content12RenderWidgetEMS2_FvPKN5blink13WebInputEventERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEEJS7_S9_SC_EEEvRKT_T0_RKSt5tupleIJDpT1_EE
#26 0x7f75fd49575f _ZN3IPC16DispatchToMethodIN7content12RenderWidgetEMS2_FvPKN5blink13WebInputEventERKN2ui11LatencyInfoENS1_22InputEventDispatchTypeEEvSt5tupleIJS6_S8_SB_EEEEvPT_T0_PT1_RKT2_
#27 0x7f75fd48ebf9 _ZN3IPC8MessageTI30InputMsg_HandleInputEvent_MetaSt5tupleIJPKN5blink13WebInputEventEN2ui11LatencyInfoEN7content22InputEventDispatchTypeEEEvE8DispatchINS9_12RenderWidgetESE_vMSE_FvS6_RKS8_SA_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#28 0x7f75fd484f66 content::RenderWidget::OnMessageReceived()
#29 0x7f75fd458e9b content::RenderViewImpl::OnMessageReceived()
#30 0x7f75f9fb9c8b IPC::MessageRouter::RouteMessage()
#31 0x7f75fceddc98 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage()
#32 0x7f75f9fb9c0e IPC::MessageRouter::OnMessageReceived()
#33 0x7f75fcee12c4 content::ChildThreadImpl::OnMessageReceived()
#34 0x7f75fc419d31 _ZN4base8internal15RunnableAdapterIMN7content8devtools4page11ColorPickerEFbRKN5blink13WebMouseEventEEE3RunIJS9_EEEbPS5_DpOT_
#35 0x7f75fd44f149 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN7content15ChildThreadImplEFbRKN3IPC7MessageEEEEE8MakeItSoIJPNS3_16RenderThreadImplES8_EEEvSB_DpOT_
#36 0x7f75fd44f0cd _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content15ChildThreadImplEFbRKN3IPC7MessageEEEEFvPS7_SB_EJNS0_17UnretainedWrapperINS6_16RenderThreadImplEEEEEENS0_12InvokeHelperILb0EvSE_EEFvSB_EE3RunEPNS0_13BindStateBaseESB_
#37 0x7f75fc202a96 base::Callback<>::Run()
#38 0x7f75fd44ece1 base::CancelableCallback<>::Forward()
#39 0x7f75fc299a01 _ZN4base8internal15RunnableAdapterIMN7content21BackgroundSyncManagerEFvRKNS_8CallbackIFvvELNS0_8CopyModeE1EEEEE3RunIJS9_EEEvPS3_DpOT_
#40 0x7f75fc299935 _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN7content21BackgroundSyncManagerEFvRKNS_8CallbackIFvvELNS0_8CopyModeE1EEEEEEE8MakeItSoINS_7WeakPtrIS4_EEJSA_EEEvSD_T_DpOT0_
#41 0x7f75fd44ef1d _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMNS_18CancelableCallbackIFvRKN3IPC7MessageEEEEKFvSA_EEEFvPKSC_SA_EJNS_7WeakPtrISC_EEEEENS0_12InvokeHelperILb1EvSF_EESB_E3RunEPNS0_13BindStateBaseESA_
#42 0x7f75fc202a96 base::Callback<>::Run()
#43 0x7f75fc3c75c8 _ZN4base8internal12InvokeHelperILb0EvNS_8CallbackIFvRKNSt7__debug3setI4GURLSt4lessIS5_ESaIS5_EEEELNS0_8CopyModeE1EEEE8MakeItSoIJSB_EEEvSE_DpOT_
#44 0x7f75fd307dd4 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS_8CallbackIFvRKN3IPC7MessageEELNS0_8CopyModeE1EEESA_JRS7_EEENS0_12InvokeHelperILb0EvSC_EEFvvEE3RunEPNS0_13BindStateBaseE
#45 0x7f760175a11e base::Callback<>::Run()
#46 0x7f760177831e base::debug::TaskAnnotator::RunTask()
#47 0x7f75e94f4754 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#48 0x7f75e94f2692 scheduler::TaskQueueManager::DoWork()
#49 0x7f75e94f9fae _ZN4base8internal15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEE3RunIJRKS4_RKbEEEvPS3_DpOT_
#50 0x7f75e94f9eaa _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEE8MakeItSoINS_7WeakPtrIS4_EEJRKS5_RKbEEEvS8_T_DpOT0_
#51 0x7f75e94f9e28 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#52 0x7f760175a11e base::Callback<>::Run()
#53 0x7f760177831e base::debug::TaskAnnotator::RunTask()
#54 0x7f76017ec91c base::MessageLoop::RunTask()
#55 0x7f76017ecbb8 base::MessageLoop::DeferOrRunPendingTask()
#56 0x7f76017ece12 base::MessageLoop::DoWork()
#57 0x7f7601803c63 base::MessagePumpDefault::Run()
#58 0x7f76017ec30f base::MessageLoop::RunHandler()
#59 0x7f7601879f84 base::RunLoop::Run()
#60 0x7f76017eb384 base::MessageLoop::Run()
#61 0x7f75fd4b0f03 content::RendererMain()
  r8: 00007fff0013d6f0  r9: 0000000000000000 r10: 0000000000000000 r11: 00007f75ee9fc870
 r12: 00007f76024a1a2c r13: 00007fff001441a0 r14: 0000000000000000 r15: 0000000000000000
  di: 0000247e16dd5200  si: 00000000fbadbeef  bp: 00007fff0013dcd0  bx: 0000000000000000
  dx: 0000000000000013  ax: 75306ff66bff8400  cx: 00000000fbadbeef  sp: 00007fff0013dc30
  ip: 00007f75eb2f5c9a efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000006
 trp: 000000000000000e msk: 0000000000000000 cr2: 00000000fbadbeef
[end of stack trace]

Comment 4 by dbeam@chromium.org, May 4 2016

Cc: sigbjo...@opera.com
Labels: Needs-Bisect

Comment 5 Deleted

Comment 6 by brajkumar@chromium.org, May 5 2016

Cc: brajkumar@chromium.org

Comment 7 by brajkumar@chromium.org, May 5 2016 

Tested this issue on Ubuntu 14.04 using chrome latest Dev M52-52.0.2725.0 by following steps mentioned in the comment #3. Observed no crashes while pressing "Tab".

Attaching screen-cast for reference. Could anyone let us know is this is the right way to reproduce this issue? If yes, What is the expected behavior?

Thanks!
UserManager.ogv
1.7 MB Download

Comment 8 by kochi@chromium.org, May 6 2016

Cc: hayato@chromium.org
Labels: -Needs-Feedback -Needs-Bisect
Owner: kochi@chromium.org
Status: Started (was: Untriaged)
Reproduced for me.  Taking this.
Project Member

Comment 9 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a82e070e5102bc29de52ddf6071018d703c304

commit 65a82e070e5102bc29de52ddf6071018d703c304
Author: kochi <kochi@chromium.org>
Date: Thu May 12 06:08:21 2016

Move asserts in FocusNavigationController.

An assertion in
FocusController::findFocusableElementAcrossFocusScopesForward and
FocusController::findFocusableElementAcrossFocusScopesBackward
assumed that focus navigation happens from a focused
element to another, but with the introduction of
sequential focus navigation starting point,
it is no longer true.

Moving the assertion to where appropriate.

BUG= 609012 
TEST=FocusControllerTest.DoNotCrash{1,2}

Review-Url: https://codereview.chromium.org/1954023002
Cr-Commit-Position: refs/heads/master@{#393194}

[modify] https://crrev.com/65a82e070e5102bc29de52ddf6071018d703c304/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/65a82e070e5102bc29de52ddf6071018d703c304/third_party/WebKit/Source/core/page/FocusControllerTest.cpp

Comment 10 by kochi@chromium.org, May 12 2016

Status: Fixed (was: Started)

Comment 11 by benhenry@chromium.org, Sep 29 2017

Components: Blink>HTML>Focus

Comment 12 by benhenry@chromium.org, Sep 29 2017

Components: -Blink>Focus
►

Sign in to add a comment