New issue
Advanced search Search tips

Issue 609009 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 600915



Sign in to add a comment

Remove AppList "DidRun" stuff from the Windows registry

Project Member Reported by tapted@chromium.org, May 4 2016

Issue description

Chrome Version       : 51.0.2704.19

app_list_service_win.cc has:

#if defined(GOOGLE_CHROME_BUILD)
void SetDidRunForNDayActiveStats() {
  DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
  base::FilePath exe_path;
  if (!PathService::Get(base::DIR_EXE, &exe_path)) {
    NOTREACHED();
    return;
  }
  bool system_install = !InstallUtil::IsPerUserInstall(exe_path);
  // Using Chrome Binary dist: Chrome dist may not exist for the legacy
  // App Launcher, and App Launcher dist may be "shadow", which does not
  // contain the information needed to determine multi-install.
  // Edge case involving Canary: crbug/239163.
  BrowserDistribution* chrome_binaries_dist =
      BrowserDistribution::GetSpecificDistribution(
          BrowserDistribution::CHROME_BINARIES);
  if (chrome_binaries_dist &&
      InstallUtil::IsMultiInstall(chrome_binaries_dist, system_install)) {
    UpdatingAppRegistrationData app_launcher_reg_data(
        installer::kAppLauncherGuid);
    GoogleUpdateSettings::UpdateDidRunStateForApp(
        app_launcher_reg_data, true /* did_run */);
  }
}
#endif  // GOOGLE_CHROME_BUILD


We need to ensure any stuff this adds to the registry isn't left behind when the app launcher is turned down.
 
Cc: benwells@chromium.org hua...@chromium.org grt@chromium.org
ccing some installer folks who know more about this. For context, we're turning down the app launcher on Win/Mac/Linux and need to clean up appropriately.

Is a call to app_launcher_installer::RemoveAppLauncherVersionKey() enough?
Yeah, I added the function in http://crrev.com/811283002 to remove the key on Chrome (non-Canary) uninstall.  Please test manually to see that the associated key indeed gets removed.  Thanks!
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 11 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Assigned)

Sign in to add a comment