Regression: Browser crash is observed on ‘chrome://interstitials/'.
Reported by
dmascare...@etouch.net,
May 4 2016
|
||||||||||
Issue descriptionChrome Version:52.0.2723.0 Revision 5e216d9b62275101c30f4a5cb2174bb68970ef3c-refs/heads/master@{#391139} 32/64 bit OS: MAC (10.10.5)(10.11.4),Windows (7, 8, 10) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://interstitials/ 2. Click middle button of the mouse on any link beneath ‘Safe Browsing’ 3. Observe. Actual: Browser crash Expected: Browser should not crash. Crash id: Crash ID fad2beb200000000 (abdb96ef-0183-47d5-9e93-85609f900b67) Crash id: Crash ID 27a2beb200000000 (c30a99c7-db04-4232-9938-c75cdc3ef719) This is regression issue, broken in ‘M52’ and will soon update the info.
,
May 4 2016
Correction Above issue is broken in ‘M 49’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/ec0f887bef7ccde03f5ec84319056346f000cd73..4fbe8b95c05f85516d90be465e1cd82e5f212646?pretty=fuller&n=100 Suspecting: r368715 ? Good build: 49.0.2618.0 Bad build: 49.0.2619.0 Kindly help to re-assign if your change is not the cause for this issue. Note: Above issue is also reproducible on Linux (ubuntu 14.04 LTS)
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c518abf63a0fdc4b7288f8180997faf0fba0083d commit c518abf63a0fdc4b7288f8180997faf0fba0083d Author: jialiul <jialiul@chromium.org> Date: Thu May 05 19:56:07 2016 Fix interstitial ui crashing when open in new tab. BUG= 609003 Review-Url: https://codereview.chromium.org/1955443002 Cr-Commit-Position: refs/heads/master@{#391880} [modify] https://crrev.com/c518abf63a0fdc4b7288f8180997faf0fba0083d/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/c518abf63a0fdc4b7288f8180997faf0fba0083d/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
,
May 5 2016
Request merge to M51 due to stability implication. Thanks!
,
May 5 2016
,
May 6 2016
Issue 609734 has been merged into this issue.
,
May 6 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e1e317decf02de93a057c0426eb4addaa285a7a commit 1e1e317decf02de93a057c0426eb4addaa285a7a Author: Jialiu Lin <jialiul@chromium.org> Date: Fri May 06 21:04:57 2016 Fix interstitial ui crashing when open in new tab. BUG= 609003 Review-Url: https://codereview.chromium.org/1955443002 Cr-Commit-Position: refs/heads/master@{#391880} (cherry picked from commit c518abf63a0fdc4b7288f8180997faf0fba0083d) Review URL: https://codereview.chromium.org/1952663007 . Cr-Commit-Position: refs/branch-heads/2704@{#428} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/1e1e317decf02de93a057c0426eb4addaa285a7a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/1e1e317decf02de93a057c0426eb4addaa285a7a/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
,
May 12 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ashej...@chromium.org
, May 4 2016