New issue
Advanced search Search tips

Issue 609002 link

Starred by 2 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Aug 2016
Cc:
dbeam@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 521040
issue 597347



Sign in to add a comment

MD Settings: Networks performance enhancements

Project Member Reported by michae...@chromium.org, May 4 2016 
<settings-internet-page> is a heavy section and needs some love, probably in the form of dom-if. One big problem I see is that it creates network lists (which have dozens of elements) even when the list cannot be shown:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/settings/internet_page/network_summary_item.html&sq=package:chromium&type=cs&l=23

^ we make the iron-collapse invisible, but still create the components in the list for the network(s).

There is also a <div class="known buttons"> in each cr-network-list-item which is hidden for me.

We also create <network-summary-item>s for network types that aren't present (e.g. wimax). An empty <network-summary-item> has 102 descendants. For users who only have wi-fi connections, that's 412 invisible elements.

End result: in a fake profile, settings-internet-page has 856 descendants (including 53 paper-icon-buttons). If I manually delete stuff that isn't visible, it goes down to 539. Hopefully we can reduce that further too, because that's still 40% of the page elements (for a stub profile).

Comment 1 by steve...@chromium.org, May 4 2016

Components: UI>Shell>Networking
Status: Available (was: Untriaged)
This section still needs a more complete spec and the entire section needs to be updated to be consistent with everything we have learned since it was implemented more than a year ago (!).

In the short term, the sub-pages should already be dom-if'd out, but it would also make sense I think to:
* dom-if the entier network-summary-item for technologies that are not available.
* dom-if out the <cr-network-list> in network_summary_item.html until it is expanded.

I should have time next week to at least do those two, if nobody else has the cycles to look into it.

(There's a bit of a learning curve with the networking configuration code, but it would also be great to have someone else get at least somewhat familiar with it).

Comment 2 by tbuck...@chromium.org, May 4 2016 

I filed crbug.com/609156 to capture any requests for additional Internet connection mocks/specs. Please add your anything else you need!

Comment 3 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-Internet

Comment 4 by tbuck...@chromium.org, May 24 2016

Labels: -Pri-1 Pri-2

Comment 5 by steve...@chromium.org, Jul 19 2016

Owner: steve...@chromium.org
Status: Started (was: Available)

Comment 6 by steve...@chromium.org, Jul 19 2016

Blocking: 521040
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f

commit b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Jul 21 17:33:48 2016

MD Settings: Internet: Reduce use of hidden for complex sections.

This cleanup CL does the following:
* Use dom-repeat to only include sections for existing device types.
* Use dom-if instead of display to show items with infrequent
  visibility changes.
* Minor layout / CSS cleanup.

BUG=609156, 609002 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2167473002
Cr-Commit-Position: refs/heads/master@{#406890}

[modify] https://crrev.com/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f/chrome/browser/resources/settings/internet_page/network_summary.html
[modify] https://crrev.com/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f/chrome/browser/resources/settings/internet_page/network_summary.js
[modify] https://crrev.com/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f/chrome/browser/resources/settings/internet_page/network_summary_item.js
[modify] https://crrev.com/b4c0d25b2cad8e2f3540f2d9b88607b5a74b339f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 8 by steve...@chromium.org, Aug 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment