screenshot.py doesn't work in VMs |
|||||
Issue descriptionThe following builders are failing VMTests: https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-telemetry https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-telemetry I tried it locally on VM image and it fails. Suspecting the most recent Roll https://codereview.chromium.org/1944873002. Could you please take a look (or triage)? We must fix this before it propagates to the PFQ. Thanks! The specific failure is the following: 05/03 20:30:19.431 INFO |run_chromeos_tests:0052| [982/1005] telemetry.core.platform_unittest.PlatformScreenshotTest.testScreenshot queued 05/03 20:30:19.431 INFO |run_chromeos_tests:0052| [983/1005] telemetry.core.platform_unittest.PlatformScreenshotTest.testScreenshot failed unexpectedly 8.0324s: 05/03 20:30:19.432 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 05/03 20:30:19.432 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/decorators.py", line 163, in wrapper 05/03 20:30:19.432 INFO |run_chromeos_tests:0052| func(*args, **kwargs) 05/03 20:30:19.433 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/core/platform_unittest.py", line 39, in testScreenshot 05/03 20:30:19.433 INFO |run_chromeos_tests:0052| img = image_util.FromPngFile(tf.name) 05/03 20:30:19.433 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/util/image_util.py", line 78, in FromPngFile 05/03 20:30:19.434 INFO |run_chromeos_tests:0052| return impl.FromPngFile(path) 05/03 20:30:19.434 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py", line 62, in FromPngFile 05/03 20:30:19.434 INFO |run_chromeos_tests:0052| return FromPng(f.read()) 05/03 20:30:19.435 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py", line 72, in FromPng 05/03 20:30:19.435 INFO |run_chromeos_tests:0052| width, height, pixels, meta = png.Reader(bytes=png_data).read_flat() 05/03 20:30:19.435 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/png/png.py", line 1952, in read_flat 05/03 20:30:19.435 INFO |run_chromeos_tests:0052| x, y, pixel, meta = self.read() 05/03 20:30:19.436 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/png/png.py", line 1914, in read 05/03 20:30:19.436 INFO |run_chromeos_tests:0052| self.preamble(lenient=lenient) 05/03 20:30:19.436 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/png/png.py", line 1711, in preamble 05/03 20:30:19.437 INFO |run_chromeos_tests:0052| self.validate_signature() 05/03 20:30:19.437 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/png/png.py", line 1698, in validate_signature 05/03 20:30:19.437 INFO |run_chromeos_tests:0052| raise FormatError("PNG file has invalid signature.") 05/03 20:30:19.438 INFO |run_chromeos_tests:0052| FormatError: FormatError: PNG file has invalid signature.
,
May 4 2016
The failing test is PlatformScreenshotTest.testScreenshot. It passes on hardware, but fails in the VM, because screenshot.py fails on a VM.
Failing stack:
localhost bin # /usr/local/autotest/bin/screenshot.py /var/tmp/foo.png
Traceback (most recent call last):
File "/usr/local/autotest/bin/screenshot.py", line 21, in <module>
image = crtcScreenshot(args.crtc)
File "/usr/local/autotest/cros/graphics/drm.py", line 402, in crtcScreenshot
fb = _drm.resources().getCrtc(crtc_id).fb()
File "/usr/local/autotest/cros/graphics/drm.py", line 148, in fb
fb = self._l.drmModeGetFB(self._fd, self.buffer_id).contents
ValueError: NULL pointer access
Our options:
1. Fix screenshot.py on VMs
2. Disable screenshots on VMs.
We really want to have screenshots on VMs because they are useful when tests fail.
I'll have a patch to disable screenshots on VMs soon.
,
May 4 2016
,
May 4 2016
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a3ee8ff040e7fd5714eb73b44b58245612f930e commit 6a3ee8ff040e7fd5714eb73b44b58245612f930e Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu May 05 03:20:12 2016 Roll src/third_party/catapult/ 6c4d3dbd3..829c320e6 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6c4d3dbd3783..829c320e69d4 $ git log 6c4d3dbd3..829c320e6 --date=short --no-merges --format='%ad %ae %s' BUG= 608414 ,609001 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/1952943002 Cr-Commit-Position: refs/heads/master@{#391741} [modify] https://crrev.com/6a3ee8ff040e7fd5714eb73b44b58245612f930e/DEPS
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df8493cd370c1e49b3717c39383b6fba13c4f7e4 commit df8493cd370c1e49b3717c39383b6fba13c4f7e4 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri May 06 01:32:53 2016 Roll src/third_party/catapult/ 5a77ca6c9..925381012 (5 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5a77ca6c9cfd..9253810122c8 $ git log 5a77ca6c9..925381012 --date=short --no-merges --format='%ad %ae %s' BUG=609001, 608414 , 608414 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/1952123005 Cr-Commit-Position: refs/heads/master@{#391981} [modify] https://crrev.com/df8493cd370c1e49b3717c39383b6fba13c4f7e4/DEPS
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd6c0ba34a71547db27d1abf9016d86e13e1b7ea commit cd6c0ba34a71547db27d1abf9016d86e13e1b7ea Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Jun 15 20:16:59 2016 Roll src/third_party/catapult/ b30d2c977..91122c7ad (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b30d2c977957..91122c7ad6ee $ git log b30d2c977..91122c7ad --date=short --no-merges --format='%ad %ae %s' BUG=609001 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2066383002 Cr-Commit-Position: refs/heads/master@{#399997} [modify] https://crrev.com/cd6c0ba34a71547db27d1abf9016d86e13e1b7ea/DEPS
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2609394812c0a998446b6f60010f0b6b78f8374 commit f2609394812c0a998446b6f60010f0b6b78f8374 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri Jun 17 01:34:17 2016 Roll src/third_party/catapult/ b2bcbcedc..727456b86 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b2bcbcedccff..727456b86fb3 $ git log b2bcbcedc..727456b86 --date=short --no-merges --format='%ad %ae %s' BUG=609001 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2078753002 Cr-Commit-Position: refs/heads/master@{#400327} [modify] https://crrev.com/f2609394812c0a998446b6f60010f0b6b78f8374/DEPS
,
Jul 11 2016
Is this issue fixed?
,
Aug 17 2016
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6b1a1edf45d883e1edafc87defe20fdfd95d09c commit c6b1a1edf45d883e1edafc87defe20fdfd95d09c Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri Aug 19 06:12:40 2016 Roll src/third_party/catapult/ b1fb8ff42..d7888dd23 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b1fb8ff42918..d7888dd23836 $ git log b1fb8ff42..d7888dd23 --date=short --no-merges --format='%ad %ae %s' BUG=631640,609001 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2260663003 Cr-Commit-Position: refs/heads/master@{#413065} [modify] https://crrev.com/c6b1a1edf45d883e1edafc87defe20fdfd95d09c/DEPS
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c533f2b2a837167931728be53c4bdee94fec749 commit 5c533f2b2a837167931728be53c4bdee94fec749 Author: nednguyen <nednguyen@google.com> Date: Wed Aug 24 15:03:01 2016 Manually roll src/third_party/catapult/ eafb38794..ae022b60c (15 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/eafb38794263..ae022b60c580 $ git log eafb38794..ae022b60c --date=short --no-merges --format='%ad %ae %s' 2016-08-24 jbudorick [devil] Use /data/local/tmp for the command line on eng + userdebug builds. 2016-08-23 achuith Can't take a screenshot on VMs. 2016-08-23 jbudorick [catapult_build] Disable telemetry tests on the Android cq bot. 2016-08-23 dtu Delete use_recipe, use_buildbucket, and tester_director_map. 2016-08-23 benjhayden Include histogram.html in several files 2016-08-23 nduca Import polymer in a single place and remove d3 hacks 2016-08-23 fmeawad v8CallStats: Fix tti calculations + Rebase after deleting pi 2016-08-23 aiolos Revert of Update chrome ref builds (patchset #1 id:1 of https://codereview.chromium.org/2264243002/ ) 2016-08-23 eakuefner [Catapult] Add would-be catapult_base binary dependency location to .gitignore 2016-08-23 jbudorick [android] Run provision_devices on the Catapult Android Tryserver. 2016-08-23 ssid MemoryMetric: Report "allocated_objects_size" from "allocated_objects" dump 2016-08-23 benjhayden Fix side-panel-container's drag-handle. 2016-08-23 eakuefner Delete leftover PI test_data file 2016-08-23 aiolos Update the Chrome Stable channel reference builds. 2016-08-23 benjhayden Display diagnostic maps in a table in histogram-span This also include the update to core.about_tracing_integration_test.AboutTracingIntegrationTest.testBasicTraceRecording test to reflect the change to record button UI. BUG=609001 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2270313004 Cr-Commit-Position: refs/heads/master@{#414072} [modify] https://crrev.com/5c533f2b2a837167931728be53c4bdee94fec749/DEPS [modify] https://crrev.com/5c533f2b2a837167931728be53c4bdee94fec749/tools/perf/core/about_tracing_integration_test.py
,
Jan 16
,
Jan 16
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by achuith@chromium.org
, May 4 2016