New issue
Advanced search Search tips

Issue 608981 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

In the Incognito switcher, the default page favicon is hard to see

Project Member Reported by ainslie@chromium.org, May 4 2016

Issue description

The little page icon is very hard to see on the incognito new tabs (for sites without favicons). The contrast isn't high enough. 

We could consider: 
1. updating the icon tinting (to match the close-x)
2. removing the icon since it doesn't provide much new signal for switching


 
Screen Shot 2016-05-03 at 5.57.36 PM.png
180 KB View Download

Comment 1 by hwi@chromium.org, May 4 2016

Option #1 icon tinting sgtm
(a related thought, we should probably think about solving this generically since when we have theme-color tabs in the switcher, we might run into this same thing non-incognito mode too)

Comment 3 by rolfe@chromium.org, May 6 2016

Alex - can you share steps to get to what you're seeing? The icon is tinted properly (to match the close icon) for me on Stable 50.0.266.89 and Dev 52.0.273.0.

Comment 4 by rolfe@chromium.org, May 6 2016

Owner: tedc...@chromium.org
Status: Assigned (was: Untriaged)
Hwi corrected the error of my ways! I was looking at the incognito tab itself. Check out the attached. I say we'd want to match wherever the faded page icon is used (chrome:// pages maybe?) to be the same as the incognito tab one.

Assigning to Ted to queue up for his team as time allows (unless this belongs to another eng group, not quite sure.)
woahtwotints.png
117 KB View Download
Cc: tedc...@chromium.org
Owner: mdjones@chromium.org
Some notes I have after looking into this:

- The asset that the NTP uses and the actual default icon are two different assets in chrome. (src/chrome/android/java/res/drawable... and src/ui/resources/...)

- It should be pretty easy to solve this problem for incognito, I would just need an incognito version of the asset on the native side (and probably an android only code block). That code is in GetDefaultFavicon(...) in chrome_content_browser_client.cc.

- Having this work for theme colors will likely require copying the logic from java and making a c++ version (the two icon sources are pretty far removed from eachother).

Comment 7 by rolfe@chromium.org, Mar 29 2017

Cc: -rolfe@chromium.org cl...@chromium.org
Removing myself and adding cleer@ as primary design contact
Cc: mdjones@chromium.org
Components: UI>Browser>Mobile>TabSwitcher
Owner: ----
Status: Available (was: Assigned)
Not sure if we want to approach this issue right now so I'm marking this as available. It seems like we would need to override Android's default icon specifically (probably in java) and maybe even theme it since there won't be a catch-all color that has perfect contrast with all possible theme colors.

Sign in to add a comment