New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608979 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 607350



Sign in to add a comment

WebView LayoutTest failing

Project Member Reported by yolandyan@chromium.org, May 4 2016

Issue description

Currently WebViewLayoutTest is failing on
org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewExcludedInterfaces
org.chromium.webview_shell.test.WebViewLayoutTest#testEMEPermission
org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces

I am working on fixing testEMEPermission(607350), the other two tests are failing started on build 12777

https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/12777

The CL that broke is most likely this:
https://chromium.googlesource.com/chromium/src/+/9ac1750adf85027985c7af3468e0b972c2086235
 
Cc: timvolod...@chromium.org

Comment 2 Deleted

mlamouri@:
hmm sounds like the issue you just fixed
The only test that is still failing is org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewExcludedInterfaces:

Failure in testWebViewExcludedInterfaces:
I   42.530s run_tests_on_device(06917dc4003be6b0)    junit.framework.AssertionFailedError: Interface [GLOBAL OBJECT].method onerror not exposed in blink
I   42.530s run_tests_on_device(06917dc4003be6b0)    	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewExcludedInterfaces(WebViewLayoutTest.java:150)
I   42.530s run_tests_on_device(06917dc4003be6b0)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I   42.530s run_tests_on_device(06917dc4003be6b0)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I   42.530s run_tests_on_device(06917dc4003be6b0)    	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I   42.530s run_tests_on_device(06917dc4003be6b0)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I   42.530s run_tests_on_device(06917dc4003be6b0)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I   42.530s run_tests_on_device(06917dc4003be6b0)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
I   42.531s run_tests_on_device(06917dc4003be6b0)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Both Android Webview L/M (dbg) bots are failing:

https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/12914/steps/Instrumentation%20test%20SystemWebViewShellLayoutTest/logs/stdio

https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20M%20(dbg)/builds/8559/steps/Instrumentation%20test%20SystemWebViewShellLayoutTest/logs/stdio
Owner: timvolod...@chromium.org
yeah I am looking at this right now
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9

commit f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9
Author: timvolodine <timvolodine@chromium.org>
Date: Thu May 05 15:05:12 2016

[WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces.

Fix exclude list due to https://codereview.chromium.org/1380503002

Should fix WebView L and WebView M AOSP bots.

BUG= 608979 , 609448 

Review-Url: https://codereview.chromium.org/1951253003
Cr-Commit-Position: refs/heads/master@{#391803}

[modify] https://crrev.com/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90cdf6675f4f91aa68fb12709c46eac1a658dc3d

commit 90cdf6675f4f91aa68fb12709c46eac1a658dc3d
Author: gsennton <gsennton@chromium.org>
Date: Mon May 09 17:02:31 2016

Revert of [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces. (patchset #2 id:20001 of https://codereview.chromium.org/1951253003/ )

Reason for revert:
Fix WebViewLayoutTest failures due to https://codereview.chromium.org/1380503002 being reverted.

Reverting the current CL and  https://codereview.chromium.org/1950943002/ (that revert is in https://codereview.chromium.org/1960923003/)

BUG= 609448 

Original issue's description:
> [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces.
>
> Fix exclude list due to https://codereview.chromium.org/1380503002
>
> Should fix WebView L and WebView M AOSP bots.
>
> BUG= 608979 , 609448 
>
> Committed: https://crrev.com/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9
> Cr-Commit-Position: refs/heads/master@{#391803}

TBR=mlamouri@chromium.org,torne@chromium.org,timvolodine@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 608979 , 609448 

Review-Url: https://codereview.chromium.org/1960203002
Cr-Commit-Position: refs/heads/master@{#392340}

[modify] https://crrev.com/90cdf6675f4f91aa68fb12709c46eac1a658dc3d/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Sign in to add a comment