Ripple/hover/focus/pressed state for location icon, especially in EV state |
||||||||||||||
Issue descriptionf6, then tab to page icon. It doesn't show focus. Press space or enter. It doesn't have a ripple. Click with the mouse, also no ripple.
,
May 4 2016
Are ripples MD-only? Should this be tagged MD Native UI?
,
May 4 2016
Yes, I simply had a hard time adding labels before because monorail wasn't cooperating.
,
May 4 2016
The focus ring part of this is covered by bug 591140 .
,
May 4 2016
,
May 18 2016
,
May 19 2016
I remember we said the icons to the left of the URL shouldn't have ripple. sgabriel@, is this still the case? Should there be ripple on the lock icon at least in some cases like with keyboard or mouse activation?
,
May 20 2016
There should be ripples with the new implementation of the chrome security icon and ev certs. I'd ask the owner of the new implementation for details (Max walker).
,
May 20 2016
+maxwalker for ripple/hover spec
,
May 31 2016
the popup blocked icon, when there's text present, also doesn't have a ripple or hover state.
,
Jun 1 2016
ping maxwalker
,
Jun 3 2016
Issue 617108 has been merged into this issue.
,
Jun 22 2016
Let's make this specifically about the location icon in its various states. Bug 591140 (for right now, may change) can cover the other location bar views. Max, we need to know how to handle hover/pressed/focus state for the location icon, primarily in the EV cert case. The other location bar child views are going to use the standard MD toolbar "grey roundrect background" state in these cases. When we have an EV cert visible, currently the hover/click region for the location icon (to trigger the origin info bubble) stretches all the way through the cert holder name. One possible resolution here would be to reduce this region to only be atop the icon itself (i.e. the same whether there's an EV cert or this is just normal HTTPS), at which point we can indicate hover/focus/press the same as with other location bar children. Another route would be to visually indicate these states like with other icons, but leave the hover region unchanged, meaning we would "highlight" the icon itself even while hovering the cert holder name. A third route would be to show some sort of hover/pressed/focus effect behind the entire icon and cert holder name.
,
Jun 29 2016
Note: This should also cover the content settings icon when in its expanded "showing a string" state.
,
Jul 11 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 4 2016
,
Sep 28 2016
Ping on this. With harmony, we're removing bubble arrows, so we really need the "active"/"hover" state for the icon when the bubble is showing. If you trust me enough, I can probably make it do something sensible without explicit design input.
,
Sep 30 2016
,
Oct 20 2016
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by est...@chromium.org
, May 4 2016