New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608976 link

Starred by 6 users

Issue metadata

Status: Duplicate
Merged: issue 588377
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 591140
issue 495654



Sign in to add a comment

Ripple/hover/focus/pressed state for location icon, especially in EV state

Project Member Reported by est...@chromium.org, May 4 2016

Issue description

f6, then tab to page icon. It doesn't show focus. Press space or enter. It doesn't have a ripple. Click with the mouse, also no ripple.
 
Labels: OS-Chrome OS-Linux OS-Windows
(monorail isn't autofilling components or labels right now)
Are ripples MD-only?  Should this be tagged MD Native UI?
Labels: -Pri-3 M-52 Proj-MaterialDesign-NativeUI Pri-2
Yes, I simply had a hard time adding labels before because monorail wasn't cooperating.
Blocking: 495654
Cc: bruthig@chromium.org
Labels: -Pri-2 Pri-3
Summary: location icon / ev cert has no ripple (was: location icon / ev cert has no focus ring or ripple)
The focus ring part of this is covered by  bug 591140 .
Labels: -M-52 -Pri-3 M-53 Pri-2
Labels: -Pri-2 Pri-3

Comment 7 by varkha@chromium.org, May 19 2016

Cc: sgabr...@chromium.org
I remember we said the icons to the left of the URL shouldn't have ripple. sgabriel@, is this still the case? Should there be ripple on the lock icon at least in some cases like with keyboard or mouse activation?
There should be ripples with the new implementation of the chrome security icon and ev certs. I'd ask the owner of the new implementation for details (Max walker).

Comment 9 by est...@chromium.org, May 20 2016

Cc: maxwalker@chromium.org
+maxwalker for ripple/hover spec
the popup blocked icon, when there's text present, also doesn't have a ripple or hover state.
ping maxwalker
Cc: nyerramilli@chromium.org est...@chromium.org tkonch...@chromium.org
 Issue 617108  has been merged into this issue.
Cc: -maxwalker@chromium.org
Owner: maxwalker@chromium.org
Status: Assigned (was: Available)
Summary: Ripple/hover/focus/pressed state for location icon, especially in EV state (was: location icon / ev cert has no ripple)
Let's make this specifically about the location icon in its various states.   Bug 591140  (for right now, may change) can cover the other location bar views.

Max, we need to know how to handle hover/pressed/focus state for the location icon, primarily in the EV cert case.  The other location bar child views are going to use the standard MD toolbar "grey roundrect background" state in these cases.  When we have an EV cert visible, currently the hover/click region for the location icon (to trigger the origin info bubble) stretches all the way through the cert holder name.  One possible resolution here would be to reduce this region to only be atop the icon itself (i.e. the same whether there's an EV cert or this is just normal HTTPS), at which point we can indicate hover/focus/press the same as with other location bar children.

Another route would be to visually indicate these states like with other icons, but leave the hover region unchanged, meaning we would "highlight" the icon itself even while hovering the cert holder name.  A third route would be to show some sort of hover/pressed/focus effect behind the entire icon and cert holder name.
Note: This should also cover the content settings icon when in its expanded "showing a string" state.
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 11 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 591140
Cc: bettes@chromium.org
Labels: -Pri-3 -M-54 M-56 Pri-1
Ping on this. With harmony, we're removing bubble arrows, so we really need the "active"/"hover" state for the icon when the bubble is showing.

If you trust me enough, I can probably make it do something sensible without explicit design input.

Comment 18 by palmer@google.com, Sep 30 2016

Cc: -palmer@chromium.org
Mergedinto: 588377
Status: Duplicate (was: Assigned)

Sign in to add a comment