New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608974 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

[1:1:0503/173341:FATAL:multibuffer_data_source.cc(573)] Check failed: preload + kPreloadHighExtra <= pin_forwards (22020096 vs. 20930330)

Project Member Reported by dalecur...@chromium.org, May 4 2016

Issue description

[1:1:0503/173341:FATAL:multibuffer_data_source.cc(573)] Check failed: preload + kPreloadHighExtra <= pin_forwards (22020096 vs. 20930330)
#0 0x7f81e2bf9dce base::debug::StackTrace::StackTrace()
#1 0x7f81e2c1a1fb logging::LogMessage::~LogMessage()
#2 0x7f81d86d7876 media::MultibufferDataSource::UpdateBufferSizes()
#3 0x7f81d86d8ef2 media::MultibufferDataSource::SetBitrateTask()
#4 0x7f81d86c337f _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN5media18BufferedDataSourceEFviEEEFvPS7_iEJNS_7WeakPtrIS7_EERiEEENS0_12InvokeHelperILb1EvSA_EEFvvEE3RunEPNS0_13BindStateBaseE
#5 0x7f81e2bfaffc base::debug::TaskAnnotator::RunTask()
#6 0x7f81d8db6527 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#7 0x7f81d8db51a5 scheduler::TaskQueueManager::DoWork()
#8 0x7f81d8db7584 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#9 0x7f81e2bfaffc base::debug::TaskAnnotator::RunTask()
#10 0x7f81e2c24985 base::MessageLoop::RunTask()
#11 0x7f81e2c24ce8 base::MessageLoop::DeferOrRunPendingTask()
#12 0x7f81e2c2507b base::MessageLoop::DoWork()
#13 0x7f81e2c26a1f base::MessagePumpDefault::Run()
#14 0x7f81e2c244b1 base::MessageLoop::RunHandler()
#15 0x7f81e2c536b0 base::RunLoop::Run()
#16 0x7f81e2c235c0 base::MessageLoop::Run()
#17 0x7f81e0e8f3fe content::RendererMain()
#18 0x7f81e0faaa0b content::RunZygote()
#19 0x7f81e0faafa2 content::RunNamedProcessTypeMain()
#20 0x7f81e0fab9e3 content::ContentMainRunnerImpl::Run()
#21 0x7f81e0faa5e0 content::ContentMain()
#22 0x7f81e344534b ChromeMain
#23 0x7f81d9a47ec5 __libc_start_main
#24 0x7f81e3445221 <unknown>

Tried to load: http://xorax.sea/star2160.mp4 in a clean ToT build and hit this. Happens consistently.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d81e2c010c6ad0fddd9d389c3208c263d3e424

commit 08d81e2c010c6ad0fddd9d389c3208c263d3e424
Author: hubbe <hubbe@chromium.org>
Date: Wed May 04 23:35:19 2016

Tweak multibuffer buffering strategy.

Separate buffer size from pin range.
Buffering is now calculated as follows:

target buffer size is max(25Mb, 12 seconds * bitrate)

prefetch_low is max(20Mb, 10 seconds * bitrate)
prefetch_high is prefetch_low + 1Mb

pin_backwards is min(2 seconds * bitrate, 25Mb - prefetch_high)
pin_forwards is 21Mb

This means that the target buffer size is equivialent to BufferedDataSource.
Note that we pin 21Mb in front of the current location no matter what, this
means that if we happen to have that data in the cache we temporarily go over
the target buffer size to avoid freeing something and then re-fetch it right
afterwards.

BUG= 608974 

Review-Url: https://codereview.chromium.org/1954493002
Cr-Commit-Position: refs/heads/master@{#391691}

[modify] https://crrev.com/08d81e2c010c6ad0fddd9d389c3208c263d3e424/media/blink/multibuffer_data_source.cc
[modify] https://crrev.com/08d81e2c010c6ad0fddd9d389c3208c263d3e424/media/blink/multibuffer_reader.cc
[modify] https://crrev.com/08d81e2c010c6ad0fddd9d389c3208c263d3e424/media/blink/multibuffer_reader.h
[modify] https://crrev.com/08d81e2c010c6ad0fddd9d389c3208c263d3e424/media/blink/multibuffer_unittest.cc

Comment 2 by hubbe@chromium.org, May 4 2016

Status: Fixed (was: Assigned)

Sign in to add a comment