I can try putting together a CL tomorrow if you are swamped.

We may also be ready to add a tricky-tot-chrome-pfq-informational-gn builder as well. I will test amd64-generic with chrome_internal next.

@stevenjb - did you assign this to me thinking that I'd add the builder? I don't know how to add pfq builders (or, really, make any changes to the chromeos waterfalls).

I was hoping you would at least know who knows. I put up a CL for this, but it's just guesswork:
https://chromium-review.googlesource.com/#/c/343930/

It sounds like dnj@ is most likely to know.

Yup, I'd go to dnj, too :).

You are trying to add this to the ToT waterfall? In that case, add the config name to the experimental PFQs section: https://chromium.googlesource.com/chromiumos/chromite/+/9586c5d20cd299c187e4bf26cd23480131d60bd3/cbuildbot/chromeos_config.py#627

After that lands, file a Chromite pin bump and ToT waterfall restart ticket at: go/bug-a-trooper.

dnj@ - I want it to be part of this waterfall:

https://build.chromium.org/p/chromiumos.chromium/waterfall

i.e. I want it to show up alongside amd64-generic-tot-chromium-pfq-informational

(I do not see veyron_rialto-chrome-pfq in that waterfall).

This is the WIP CL:
https://chromium-review.googlesource.com/#/c/343930/

Ah yeah that one is more manual. Once your CL lands ping me and I'll add it. Will this need to run VMTests?

It should be identical to https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-chromium-pfq-informational, so yes.

(That CL is waiting for your review btw)

I don't generally review Chromite CLs, do you feel my review is necessary here?

Sigh. Well, could you at least comment on it? Don seems uncertain, is there anyone else who should review it?

Sorry, not trying to be difficult. I genuinely don't have enough experience with ChromeOS build internals to say whether the parameters that you set up are reasonable.

Consider dgarrett@, akeshet@, davidjames@, or vapier@. All of them have worked extensively with CrOS build parameters.

+dgarrett@

Ah. I was comfortable with the new build config, but uncertain about how to add it to the waterfall. 

Cool. I will ping dnj@ once the CL lands about adding it to the waterfall.
Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0af7ec6ca40a024f792a9db2cb517be42b82930c

commit 0af7ec6ca40a024f792a9db2cb517be42b82930c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue May 10 16:41:34 2016

Add config for amd64-generic-tot-chromium-pfq-informational-gn

BUG= chromium:608972 
TEST=TBD

Change-Id: Iad50e1c39a3fca6e87caf7da3818ec6b460c1fab
Reviewed-on: https://chromium-review.googlesource.com/343930
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/0af7ec6ca40a024f792a9db2cb517be42b82930c/cbuildbot/config_dump.json
[modify] https://crrev.com/0af7ec6ca40a024f792a9db2cb517be42b82930c/cbuildbot/config_lib.py
[modify] https://crrev.com/0af7ec6ca40a024f792a9db2cb517be42b82930c/cbuildbot/chromeos_config.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3a6cf2da51024774e3c79f17b0790039ec55d3e9

commit 3a6cf2da51024774e3c79f17b0790039ec55d3e9
Author: dnj@chromium.org <dnj@chromium.org>
Date: Fri May 13 03:15:55 2016

CrOS: New Builder for chromiumos.chromium.

Add "amd64-generic-tot-chromium-pfq-informational-gn" builder to
"chromiumos.chromium" waterfall. Steal a slave from "chromiumos" and
update its pool.

TBR=stip@chromium.org
BUG= chromium:608972 
TEST=None

Review-Url: https://codereview.chromium.org/1978723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300569 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/3a6cf2da51024774e3c79f17b0790039ec55d3e9/masters/master.chromiumos.chromium/master_chromium_cfg.py
[modify] https://crrev.com/3a6cf2da51024774e3c79f17b0790039ec55d3e9/masters/master.chromiumos.chromium/slaves.cfg
[modify] https://crrev.com/3a6cf2da51024774e3c79f17b0790039ec55d3e9/masters/master.chromiumos/slave_pool.json
[modify] https://crrev.com/3a6cf2da51024774e3c79f17b0790039ec55d3e9/masters/master.chromiumos/slaves.cfg

You didn't quite ping me, so I hope I'm not being presumptuous, but I have updated the waterfall and allocated a slave for the builder: https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/amd64-generic-tot-chromium-pfq-informational-gn

You beat me to it! It's running and green, woohoo! Thanks everyone!

Sweet!

Bulk verified

bulk verified

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8c6708fe94504eda583a10239bd59e82730cc381

commit 8c6708fe94504eda583a10239bd59e82730cc381
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jun 17 17:21:57 2016

Add gn for all informational configs

BUG= chromium:608972 
TEST=cbuildbot with new -gn configurations

Change-Id: Ic85740d5fc7e4663b402df19cd3da4afb9c066d4
Reviewed-on: https://chromium-review.googlesource.com/353660
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/8c6708fe94504eda583a10239bd59e82730cc381/cbuildbot/config_dump.json
[modify] https://crrev.com/8c6708fe94504eda583a10239bd59e82730cc381/cbuildbot/config_lib.py
[modify] https://crrev.com/8c6708fe94504eda583a10239bd59e82730cc381/cbuildbot/chromeos_config.py

Re-purposing for all pfq-informational-gn builders

dnj@ - 

Can you add the following to chromiumos.chromium:

x86-generic-tot-chromium-pfq-informational-gn
daisy-tot-chromium-pfq-informational-gn
(amd64-generic-tot-chromium-pfq-informational-gn already exists)

And the following to chromeos.chrome:

x86-alex-tot-chrome-pfq-informational-gn
lumpy-tot-chrome-pfq-informational-gn 
tricky-tot-chrome-pfq-informational-gn 
peach_pit-tot-chrome-pfq-informational-gn 

Thanks!

Note: The -gn builders will not need to be up for long, as soon as they cycle green (and we verify a couple of other things) we will make GN the default and remove the -gn builders and configurations.

Actually RE #28, any reason you can't just use the tryserver for this then? Setting up new builders, allocating machines for them, and restarting the waterfall to instantiate them is a lot of effort for potentially single-use builders.

I've been able to run cbuildbot on the tryserver for the configurations in comment #27 (once I was pointed at https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/etc for first time try builds).

They all passed, hooray!

We'll keep just amd64-generic on the waterfall so we have some coverage until we decide to make GN the default, but we should be OK without adding the others.