New issue
Advanced search Search tips

Issue 608941 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 649068

Blocking:
issue 546836



Sign in to add a comment

[Autofill] [Passwords] Need mocks for empty sections

Project Member Reported by hcarmona@chromium.org, May 3 2016

Issue description

Need mocks for empty sections. Current empty sections look like attached screenshots.
 
EmptyAutofill.png
45.1 KB View Download
EmptyPasswords.png
50.6 KB View Download
OldEmptyAutofill.png
92.0 KB View Download
OldEmptyPasswords.png
110 KB View Download
Components: UI>Settings
Labels: Hotlist-MD-Settings-PasswordsForms

Comment 2 by bettes@chromium.org, Aug 17 2016

What's the help center article attached to those Learn more links? 

I've updated the mocks to reflect empty states. Use the standard 13pt paper grey 800 for 

"No passwords were found" 
"No addresses were found" 

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Passwords_forms.png%3Fz=width
Screen Shot 2016-08-16 at 7.08.35 PM.png
49.4 KB View Download
Cc: bettes@chromium.org
Owner: hcarmona@chromium.org
@hcarmona let us know if you need anything else!
This looks good, I'll add this text.

A few questions:

a. "No credit cards were found" as a placeholder for credit cards?
b. "No never saved passwords were found" sounds awkward. What are we calling sites for which passwords are "never save"?
c. Do we want to use these same placeholders when no results are found for passwords/exceptions also?
For #4b:
Maybe avoid the double negatives and have "Passwords saved for all websites" as the text for the password exceptions placeholder?
Adding screenshots.

The placeholders don't show up when searching and there are no results.
autofill.png
50.9 KB View Download
autofill-none.png
31.1 KB View Download
passwords.png
63.2 KB View Download
passwords-none.png
50.5 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0

commit a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0
Author: hcarmona <hcarmona@chromium.org>
Date: Tue Aug 30 22:16:03 2016

Add placeholders when lists are empty for passwords and autofill.

BUG=608941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277963002
Cr-Commit-Position: refs/heads/master@{#415455}

[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/app/settings_strings.grdp
[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Cc: hcarmona@chromium.org
Owner: bettes@chromium.org
Is the wording OK for all 4 sections? (In particular the wording for the Passwords > "Never Saved" section)

Also, do we want to show anything special when searching and there are no matches? Or is an empty list OK in that case?
"Passwords saved for all websites" is fine with me.

Let's show "No matches found" if there are none in a given section instead of having it be empty.
Owner: hcarmona@chromium.org
Blockedon: 671375
Blockedon: -671375
Blocking: 671375
Blockedon: 649068
 Issue 649068  proposes new strings for the empty lists.

This issue just needs to add "No matches found" when searching and there are no results.
Blocking: -671375
@hcarmona any updates on this issue?
Components: UI>Browser>Autofill

Sign in to add a comment