[Autofill] [Passwords] Need mocks for empty sections |
|||||||
Issue descriptionNeed mocks for empty sections. Current empty sections look like attached screenshots.
,
Aug 17 2016
What's the help center article attached to those Learn more links? I've updated the mocks to reflect empty states. Use the standard 13pt paper grey 800 for "No passwords were found" "No addresses were found" https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Passwords_forms.png%3Fz=width
,
Aug 22 2016
@hcarmona let us know if you need anything else!
,
Aug 23 2016
This looks good, I'll add this text. A few questions: a. "No credit cards were found" as a placeholder for credit cards? b. "No never saved passwords were found" sounds awkward. What are we calling sites for which passwords are "never save"? c. Do we want to use these same placeholders when no results are found for passwords/exceptions also?
,
Aug 23 2016
For #4b: Maybe avoid the double negatives and have "Passwords saved for all websites" as the text for the password exceptions placeholder?
,
Aug 24 2016
Adding screenshots. The placeholders don't show up when searching and there are no results.
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0 commit a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0 Author: hcarmona <hcarmona@chromium.org> Date: Tue Aug 30 22:16:03 2016 Add placeholders when lists are empty for passwords and autofill. BUG=608941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2277963002 Cr-Commit-Position: refs/heads/master@{#415455} [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/app/settings_strings.grdp [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js [modify] https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
,
Aug 30 2016
Is the wording OK for all 4 sections? (In particular the wording for the Passwords > "Never Saved" section) Also, do we want to show anything special when searching and there are no matches? Or is an empty list OK in that case?
,
Jan 6 2017
"Passwords saved for all websites" is fine with me. Let's show "No matches found" if there are none in a given section instead of having it be empty.
,
Jan 6 2017
,
Jan 6 2017
,
Jan 9 2017
Issue 649068 proposes new strings for the empty lists. This issue just needs to add "No matches found" when searching and there are no results.
,
Mar 17 2017
,
May 1 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbuck...@chromium.org
, May 30 2016Labels: Hotlist-MD-Settings-PasswordsForms