New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608936 link

Starred by 1 user
Status: Fixed
Owner:
█ l...@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
fmea...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac ThreadTicks should also include System time.

Project Member Reported by fmea...@chromium.org, May 3 2016 
All the other platforms provide a combined version of the CPU time (user + system), on mac they are provided separately, and we should include both.

Although splitting them into 2 different fields can provide a value, but usually the system portion is negligible.

Related Code: https://code.google.com/p/chromium/codesearch#chromium/src/base/time/time_mac.cc&l=94
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89c5c64c72a737a52426df0f29146fb530b9129c

commit 89c5c64c72a737a52426df0f29146fb530b9129c
Author: lpy <lpy@chromium.org>
Date: Thu May 05 00:37:39 2016

Include system time in Mac ThreadTicks.

Currently Mac ComputeThreadTicks doesn't only use user time, this patch includes
system time in order to get more accurate CPU time.

BUG= 608936 

Review-Url: https://codereview.chromium.org/1946303003
Cr-Commit-Position: refs/heads/master@{#391717}

[modify] https://crrev.com/89c5c64c72a737a52426df0f29146fb530b9129c/base/time/time_mac.cc

Comment 2 by l...@chromium.org, May 5 2016

Status: Fixed (was: Available)

Comment 3 by benhenry@google.com, Feb 2 2017

Components: Speed>Tracing
Labels: -Performance-Tracing
►

Sign in to add a comment