New issue
Advanced search Search tips

Issue 608901 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

PDFExtensionTest.Load/5, PDFTestFiles_PDFExtensionTest.Load_9 failing on clang/win bots that do official builds

Project Member Reported by thakis@chromium.org, May 3 2016

Issue description

Probably broken in regular official builds too; started recently (on the pinned bots too):

https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/6129
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%20tester/builds/3071

dsinclair, both builds have your https://codereview.chromium.org/1937273002 which on the surface looks harmless but actually brought in a few pdfium changes (https://pdfium.googlesource.com/pdfium.git/+log/a86d113be692153d..fd670fdef8984fd7f882). Can you check if one of them broke pdfium tests in official builds?


If you can't reproduce this in a regular official chrome build, please give this back to us.
 
Cc: thestig@chromium.org
Status: Started (was: Untriaged)
Running pdfium_test on pdf_private/interactiveform_enabled.pdf causes the test app to SEGV. PDFium revert is in the CQ: https://codereview.chromium.org/1947093002/.  Will roll DEPS once it lands.
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2660f610c7a6fd5ab69b180bb717111c8b1c1b96

commit 2660f610c7a6fd5ab69b180bb717111c8b1c1b96
Author: dsinclair <dsinclair@chromium.org>
Date: Wed May 04 16:41:04 2016

Roll src/third_party/pdfium/ fd670fdef..696fc8b70 (6 commits).

https://pdfium.googlesource.com/pdfium.git/+log/fd670fdef898..696fc8b70c19

$ git log fd670fdef..696fc8b70 --date=short --no-merges --format='%ad %ae %s'
2016-05-04 dsinclair Revert of Remove unneeded CPVT classes. (patchset #7 id:140001 of https://codereview.chromium.org/1919283008/ )
2016-05-04 tsepez Replace IFX_MemoryAllocator::Release() with delete.
2016-05-04 tsepez Remove unused CFX_CPLTree<> template
2016-05-03 tsepez Cleanup XFA-Specific memory allocators.
2016-05-03 dsinclair Remove FWL_WGTHITTEST_* defines in favour of enum class.
2016-05-03 weili Revert of Relax a couple checks to allow certain non-standard PDF files. (patchset #1 id:1 of https://codereview.chromium.org/1926823002/ )

BUG= chromium:608901 

Review-Url: https://codereview.chromium.org/1946263002
Cr-Commit-Position: refs/heads/master@{#391537}

[modify] https://crrev.com/2660f610c7a6fd5ab69b180bb717111c8b1c1b96/DEPS

Status: Fixed (was: Started)
This should be fixed once the builders pickup the DEPS change. Please let me know if there are still issues.
Cc: thakis@chromium.org och...@chromium.org rsesek@chromium.org dsinclair@chromium.org
 Issue 609019  has been merged into this issue.
Components: Internals>Plugins>PDF

Sign in to add a comment