New issue
Advanced search Search tips

Issue 608878 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

AudioParamHandler should check that destinationNode exists

Project Member Reported by rtoy@chromium.org, May 3 2016 
In  issue 605726 , the connection between the AudioParamHandler and the context was removed in favor of a connection to the AudioDestinationHandler.

But in the creation the the AudioParam, we should check that the destination actually exists before creating the AudioParam.
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7722027437aa40e2c7b33bc92a4dc278daec2d0

commit d7722027437aa40e2c7b33bc92a4dc278daec2d0
Author: rtoy <rtoy@chromium.org>
Date: Fri May 06 18:16:10 2016

Assert destination handler exists in AudioParam

AudioParam's require the destination handler to exist because they
need access to the sample rate and such.  Make sure it exists.

Also, don't call initialize() in the OfflineAudioContext constructor
if we failed to construct the context completely.

BUG= 608878 
TEST=none

Review-Url: https://codereview.chromium.org/1951903003
Cr-Commit-Position: refs/heads/master@{#392100}

[modify] https://crrev.com/d7722027437aa40e2c7b33bc92a4dc278daec2d0/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/d7722027437aa40e2c7b33bc92a4dc278daec2d0/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/d7722027437aa40e2c7b33bc92a4dc278daec2d0/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp

Comment 2 by rtoy@chromium.org, May 9 2016

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment