New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 608877 link

Starred by 4 users
Status: Duplicate
Merged: issue 585218
Owner:
r...@chromium.org
Closed: Jan 2017
Cc:
abodenha@chromium.org
sadrul@chromium.org
█ roc...@chromium.org
sky@chromium.org
mark@chromium.org
█ zelidrag@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Design doc for crash reporting on mustash

Project Member Reported by jamescook@chromium.org, May 3 2016 
We need a design doc for how crash reporting is going to work. It would be good to have this by end of May.

Notes from meeting with rkc, rockot and jamescook:

Init breakpad
Initialize breakpad or crashpad in main()

mojo_runner on desktop:
https://code.google.com/p/chromium/codesearch#chromium/src/services/shell/standalone/desktop/main_helper.cc&sq=package:chromium&type=cs

chrome --mash
Content’s main

Upload symbols for .mojo files from buildbots
	Ticket for infra
	Do we want a new product ID? Lets us customize the crash UI.
But it would be good to use Chrome’s, which has nice customizations
It should be part of the existing Chrome (for Chrome OS) view
	We may be running mash in the field as an experiment on some channels

Who uploads the crash?
	Chrome right now, but this will need to be componentized
	Is this in components/crash?

Opt-in story
	Part of existing OOBE

Comment 1 by jamescook@chromium.org, May 3 2016

Cc: sky@chromium.org
+sky - apparently the .mojo files are statically linked into the Chrome binary in release builds, so we may not even need separate upload of symbols.

Note for rkc: The mustash version of chrome, the one you can run with chrome --mash, depends on mus, which only builds with GN. The Chrome-for-Chrome OS builders are in the process of being converted to GN, but don't be surprised if this stuff doesn't show up in existing GYP builds. stevenjb@ is tracking progress of converting the official builders to GN -- it should happen soon.

Comment 2 by jamescook@chromium.org, May 3 2016 

Zel recommends not reusing the Chrome_ChromeOS component in the crash browsing tool, but instead to make a new one like Chrome_ChromeOS_mustash. He thinks infra can set a config option to make it look like Chrome_ChromeOS (which gets the customizations), but as a separate component it will be easier to see the crash volume. If it's lumped in with Chrome_ChromeOS we may get lost in the noise.

Comment 3 by sadrul@chromium.org, May 11 2016

Cc: sadrul@chromium.org

Comment 4 by r...@chromium.org, May 16 2016

Cc: mmentovai@chromium.org zelidrag@chromium.org
Since this isn't something we need to get out in the field ASAP, we should wait till Crashpad for Chrome OS is ready before moving forward with this. I believe this should be sometime around July'ish?

Adding Mark to keep me honest.

Comment 5 by r...@chromium.org, May 16 2016 

To clarify, Crashpad for Chrome on Chrome OS.

Comment 6 by mark@chromium.org, May 16 2016

Cc: -mmentovai@chromium.org mark@chromium.org
Android’s happening now, should be a couple of months. Chrome OS shouldn’t be too much further behind.

Comment 7 by jamescook@chromium.org, May 16 2016 

I would like there to be at least a plan/design by the end of the quarter.

Comment 8 by st...@chromium.org, Aug 24 2016

Owner: st...@chromium.org

Comment 9 by st...@chromium.org, Aug 24 2016

Labels: -Pri-2 M-55 Pri-1

Comment 10 by st...@chromium.org, Aug 24 2016

Cc: abodenha@chromium.org
Since Crashpad for Android/Linux has now been moved to Q4, we're now planning on implementing this using Breakpad.

Comment 11 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS
Labels: Proj-Mustash

Comment 12 by st...@chromium.org, Oct 6 2016

Labels: -M-55 M-56
Status: Started (was: Assigned)

Comment 13 by st...@chromium.org, Jan 17 2017

Mergedinto: 585218
Status: Duplicate (was: Started)

Comment 14 by st...@chromium.org, Mar 3 2017

Owner: r...@chromium.org

Comment 15 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 16 by lafo...@chromium.org, Feb 26 2018

Components: -MUS
►

Sign in to add a comment