Physical Web onboarding tests are broken |
||
Issue descriptionWe have two tests for behavior specific to the Physical Web onboarding state: UrlManagerTest#testAddUrlWhileOnboardingMakesNotification ListUrlsActivityTest#testUrlsListEmptyInOnboarding They pass locally but break the trybots when submitting new changes.
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb7110459875ee2e30ab80fcf99ed16123c39899 commit cb7110459875ee2e30ab80fcf99ed16123c39899 Author: cco3 <cco3@chromium.org> Date: Mon May 09 23:28:38 2016 Test thread equality when initiating PWEnv class ThreadUtils.assertOnUiIThread doesn't work on newer versions of Android. Instead, we should simply test thread equality to make sure we don't create a PhysicalWebEnvironment singleton twice. This change also renables Physical Web onboarding tests that had been disabled due to this issue. BUG= 608872 Review-Url: https://codereview.chromium.org/1955173003 Cr-Commit-Position: refs/heads/master@{#392471} [modify] https://crrev.com/cb7110459875ee2e30ab80fcf99ed16123c39899/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java [modify] https://crrev.com/cb7110459875ee2e30ab80fcf99ed16123c39899/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java [modify] https://crrev.com/cb7110459875ee2e30ab80fcf99ed16123c39899/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
,
May 10 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by cco3@chromium.org
, May 6 2016