GN: changes in .def files don't force relinking |
||
Issue descriptionIn GN you can list module definition files (*.def) as sources. This will automatically promote them to be arguments /DEF:... on the link line for that target. But changes in the def file doesn't look like it forces a re-link. Currently the def file is added to the input deps. This sounds like it should work but this is added as an order-only dependency on all source file compilations for that target. This is neither necessary (since those build steps don't depend on the .def file at all) nor solves the problem (it needs to a non-order-only dependency on the link line).
,
Jun 21 2016
I can't repro this bug. This was my test: ninja -C out\gn_release chrome_elf touch chrome_elf\chrome_elf.def ninja -C out\gn_release chrome_elf The second invocation of ninja triggered a relink of chrome_elf.dll. Unless there is a reason to believe that this is not representative then this bug is fixed.
,
Jun 21 2016
The code looks like it does the right thing. The .def file is listed as an implicit input. |
||
►
Sign in to add a comment |
||
Comment 1 by dpranke@chromium.org
, Jun 21 2016Cc: brucedaw...@chromium.org
Components: Build
Labels: -Build-Tools-GN Proj-GN-Migration