Add metrics for the notices about other forms of browsing history |
|||||||||
Issue descriptionIn the header of the history page, footer of the CBD dialog, and an additional dialog atop the CBD dialog, we show a notice about the existence of other forms of browsing history to those users for whom it is relevant. To gain more insight about how often the notices are shown, and what is the ratio of users seeing the notices (i.e. for how many of our users is the notice relevant), we need to add UMA metrics.
,
May 4 2016
+msarda@ can you please do the equivalent for CBD on iOS?
,
May 11 2016
This has by now passed through Canary. Requesting merge to M51 - this change only records histograms.
,
May 11 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/652a941252897dab408493439dde760b5097d9a3 commit 652a941252897dab408493439dde760b5097d9a3 Author: msarda <msarda@google.com> Date: Wed May 11 11:51:00 2016
,
May 11 2016
I will merge the CL https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/652a941252897dab408493439dde760b5097d9a3# on the Bling tree this week.
,
May 11 2016
Asking for Merge to M51 again as a new change has landed on this bug for iOS.
,
May 12 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/022ff6bd7a22015831cd164c1275b908b34921ac commit 022ff6bd7a22015831cd164c1275b908b34921ac Author: msramek <msramek@chromium.org> Date: Thu May 12 11:02:24 2016 Add histograms for notices about other forms of browsing history Notices about the existence of other forms of browsing history on history.google.com are shown to users in the header of the History page, footer of the Clear Browsing Data dialog, and an additional dialog on top of the CBD dialog after history deletion; but only to those users for whom they are relevant. This CL adds histograms that are recorded whenever one of the described UI elements is shown and records whether we also showed the notice or not (thus computing the amount and ratio of users for whom we decided to show the notice). Implemented: - History page (shared between Desktop and Android) - History page (iOS) - CBD dialog (Desktop WebUI) - CBD dialog (Desktop MD, only the footer) - CBD dialog (Android) Missing (will be added in followup CLs): - CBD dialog (iOS) - not part of Chromium repo - CBD dialog (Desktop MD, history deletion dialog) - does not exist yet BUG= 608842 TBR=dbeam@chromium.org,jyquinn@chromium.org,dfalcantara@chromium.org,rkaplow@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1948633002 Cr-Commit-Position: refs/heads/master@{#391682} (cherry picked from commit 1f22966d3e45226f3048405f9f5d7d6898285d76) NOTE! A conflict appeared in chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc, as in the 2704 branch this file does not contain the functionality which the histogram was supposed to measure. There, we simply keep the state of the file on HEAD. Review-Url: https://codereview.chromium.org/1968983002 Cr-Commit-Position: refs/branch-heads/2704@{#519} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/022ff6bd7a22015831cd164c1275b908b34921ac/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java [modify] https://crrev.com/022ff6bd7a22015831cd164c1275b908b34921ac/chrome/browser/android/preferences/pref_service_bridge.cc [modify] https://crrev.com/022ff6bd7a22015831cd164c1275b908b34921ac/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/022ff6bd7a22015831cd164c1275b908b34921ac/chrome/browser/ui/webui/options/clear_browser_data_handler.cc [modify] https://crrev.com/022ff6bd7a22015831cd164c1275b908b34921ac/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc [modify] https://crrev.com/022ff6bd7a22015831cd164c1275b908b34921ac/tools/metrics/histograms/histograms.xml
,
May 12 2016
Merged the Desktop and Android parts.
,
May 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/7ff1590952acfae9b4a872509c8ef981d829940e commit 7ff1590952acfae9b4a872509c8ef981d829940e Author: msarda <msarda@google.com> Date: Wed May 11 11:51:00 2016
,
May 12 2016
,
May 18 2016
msarda@ : Could you please help us verifying it if there is any steps to be followed from Test Engg team if it can be verified.
,
May 18 2016
I do not think this can be verified by the test team as we're just adding metrics (histograms) in this CL. I do not think the test team manually tests CLs that just add metrics. You may check if the histograms History.ClearBrowsingData.ShownHistoryNoticeAfterClearing, History.ShownHeaderAboutOtherFormsOfBrowsingHistory and History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated have any data. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, May 4 2016