New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608832 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 590784



Sign in to add a comment

chromeos-pfq: veryron_rilato-chrome-pfq failure for missing <X11/keysymdef.h>

Project Member Reported by jen...@chromium.org, May 3 2016

Issue description

veryron_rilato-chrome-pfq has been failing for missing <X11/keysymdef.h> since 5/1/2016.

https://chromegw.corp.google.com/i/chromeos/builders/veyron_rialto-chrome-pfq/builds/53

The error is seen in the log:
https://chromegw.corp.google.com/i/chromeos/builders/veyron_rialto-chrome-pfq/builds/53/steps/SimpleChromeWorkflow/logs/stdio

FAILED: obj/remoting/host/linux/remoting_host.unicode_to_keysym.o 
armv7a-cros-linux-gnueabi-g++ -B/tmp/cbuildbot-tmpIKMqYc/chrome-sdk-cacheDKi3Ud/cache/chrome-sdk/tarballs/veyron_rialto+__b__cbuild__internal_master__buildbot_archive__veyron_rialto-chrome-pfq__R52-8269.0.0-rc1+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51-gold -MMD -MF obj/remoting/host/linux/remoting_host.unicode_to_keysym.o.d -DBINARY_CORE=1 -DBINARY_DESKTOP=2 -DBINARY_HOST_ME2ME=3 -DBINARY_NATIVE_MESSAGING_HOST=4 -DBINARY_REMOTE_ASSISTANCE_HOST=5 -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=267383-1 -DCOMPONENT_BUILD -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_OZONE=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_UDEV -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -D__ARMEL__ -D__arm__ -DNVALGRIND '-DHOST_BUNDLE_NAME="ChromotingHost.bundle"' '-DPREFPANE_BUNDLE_NAME="Chromoting.prefPane"' -DVERSION=52.0.2722.0 -DTOOLKIT_VIEWS=1 -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DWEBRTC_POSIX -DCHROMEOS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DWEBRTC_CHROMIUM_BUILD -DUSE_LIBPCI=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../third_party/skia/include/utils -I../../third_party/khronos -I../../gpu -I../../skia/config -Igen/angle -I../../third_party/WebKit/Source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/webrtc_overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/policy -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -Igen/ui/views/resources -Werror -pthread -fno-strict-aliasing -Wall -Wno-extra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -I/tmp/cbuildbot-tmpIKMqYc/chrome-sdk-cacheDKi3Ud/cache/chrome-sdk/tarballs/veyron_rialto+__b__cbuild__internal_master__buildbot_archive__veyron_rialto-chrome-pfq__R52-8269.0.0-rc1+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nss -I/tmp/cbuildbot-tmpIKMqYc/chrome-sdk-cacheDKi3Ud/cache/chrome-sdk/tarballs/veyron_rialto+__b__cbuild__internal_master__buildbot_archive__veyron_rialto-chrome-pfq__R52-8269.0.0-rc1+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nspr -Wno-maybe-uninitialized -march=armv7-a -mtune=generic-armv7-a -mfpu=neon -mfloat-abi=hard -mthumb --sysroot=/tmp/cbuildbot-tmpIKMqYc/chrome-sdk-cacheDKi3Ud/cache/chrome-sdk/tarballs/veyron_rialto+__b__cbuild__internal_master__buildbot_archive__veyron_rialto-chrome-pfq__R52-8269.0.0-rc1+sysroot_chromeos-base_chromeos-chrome.tar.xz -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -g -pipe -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard -D__google_stl_debug_vector=1 -gsplit-dwarf -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-abi -std=gnu++11 -Wno-narrowing -Wno-literal-suffix  -c ../../remoting/host/linux/unicode_to_keysym.cc -o obj/remoting/host/linux/remoting_host.unicode_to_keysym.o
../../remoting/host/linux/unicode_to_keysym.cc:27:27: fatal error: X11/keysymdef.h: No such file or directory
 #include <X11/keysymdef.h>
                           ^
compilation terminated.

I guess something might be changed in veyron-rialto ebuild overlay so that this is no longer included in the build package? Since veyron-rialto is a headless device, so maybe the X11 is removed from the ebuild?
 
Labels: OS-Chrome
Blocking: 590784
Here is a recent failure:

https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_rialto-chrome-pfq/builds/112/steps/SimpleChromeWorkflow/logs/stdio

Note: The failure is with SimpleChrome running with GYP. We are working on migrating the SimpleChromeWorkflow to use GN but it's not as straightforward as one might hope.

Comment 4 by joth@chromium.org, May 18 2016

@stevenjb, thanks for the info. I was indeed wondering if this is a gyp on GN build.

- It seems probable the issue stems from Rialto setting -xkbcommon USE flag.
- I'm having trouble reproing local to confirm that (mix of not having chrome_internal set, then stumbling through a lot of new git access control errors when I do set it)
- A quick scan suggests rialto is the only thing setting -xkbcommon which would answer why no other board hit this too.
- Scanning CrOS and Chrome diffs around May 1st, nothing at all jumps out to suggest what changed to make it start failing just then.
   ..see https://crosland.corp.google.com/log/8260.0.0..8269.0.0 and
 https://chromium.googlesource.com/chromium/src/+log/52.0.2719.0..52.0.2721.0?pretty=fuller&n=10000

 
I'll keep digging

Comment 5 by joth@chromium.org, May 18 2016

Oh and the actual question I meant to ask: what exactly is remoting/host/... package? Is it the bit that allows you to remote to another machine (that's my guess) or the bit that allows the local machine to be remoted into?

Comment 6 by joth@chromium.org, May 19 2016

To recreate, I did this:

cros chrome-sdk --board=veyron_rialto --sdk-path=gs://chromeos-image-archive/veyron_rialto-release/R52-8341.0.0/
gclient runhooks
ninja -C out_${SDK_BOARD}/Release -j500 chrome chrome_sandbox nacl_helper

-> gives the OP error.

The fix (workaround) is pretty simple:
https://codereview.chromium.org/1997533002/

...

Also looks like the reason Rialto removed xkbcommon no longer applies (presumably since moving from app_shell to chrome, but could be other X11 / ozone changes in last year) so doing this too: 
https://chrome-internal-review.googlesource.com/259717
(but guessing this will take a while to bubble through to a new chrome-sdk that the pfq can build against)
Project Member

Comment 7 by bugdroid1@chromium.org, May 19 2016

Comment 8 by joth@chromium.org, May 20 2016

Status: Fixed (was: Untriaged)
Adding xkbcommon into the rialto build has fixed this as it implicitly pulls in X11 header files.

https://codereview.chromium.org/1997533002/ is still useful to fix the underlying issue (so chrome can correctly build without X11) but that's now not strictly necessar for this bug
Labels: VerifyIn-53
Labels: VerifyIn-54

Comment 12 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 30 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/622cd4c8344b3b4e4057d44bd4a1d94b4422399f

commit 622cd4c8344b3b4e4057d44bd4a1d94b4422399f
Author: Rahul Chaturvedi <rkc@google.com>
Date: Fri Sep 30 18:30:38 2016

Do not build unicode_to_keysym.cc when use_x11 == 0

BUG= 608832 

Review-Url: https://codereview.chromium.org/1997533002
Cr-Commit-Position: refs/heads/master@{#395162}
(cherry picked from commit 02dfd6d2723ed54559156a1b491c53dc596f898e)

Review URL: https://codereview.chromium.org/2380373002 .

Cr-Commit-Position: refs/branch-heads/2661@{#703}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/622cd4c8344b3b4e4057d44bd4a1d94b4422399f/remoting/host/BUILD.gn
[modify] https://crrev.com/622cd4c8344b3b4e4057d44bd4a1d94b4422399f/remoting/remoting_host.gypi
[modify] https://crrev.com/622cd4c8344b3b4e4057d44bd4a1d94b4422399f/remoting/remoting_test.gypi

Sign in to add a comment