New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 608816 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac framework deps in media/gpu (gn build) need cleanup

Project Member Reported by markdittmer@chromium.org, May 3 2016

Issue description

This was missed in content/common/gpu/media => media/gpu refactor.
 
Cc: mark@chromium.org erikc...@chromium.org
Labels: OS-Mac
Owner: markdittmer@chromium.org
Status: Assigned (was: Untriaged)
Waiting on  crbug.com/580152  before landing https://codereview.chromium.org/1938113002/ on this issue (as per discussion in CL).
Please clarify why this is a blocker? We don't run Chrome on 10.8 or older any more, and we link against the 10.10 SDK, so there shouldn't be anything that prevents you from dropping unecessary Mac frameworks.
*Whoops, to clarify, I meant https://bugs.chromium.org/p/chromium/issues/detail?id=580152 should not block you.
Blockedon: -580152
My mistake. Please clarify ask for changes to proposed CL (in CL comments).
Project Member

Comment 6 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/406527c97434a63dea38c3b77024f8dde2765c34

commit 406527c97434a63dea38c3b77024f8dde2765c34
Author: markdittmer <markdittmer@chromium.org>
Date: Wed May 04 19:19:27 2016

Sync media/gpu gyp and gn Mac framework deps (copy gyp => gn)

BUG= 608816 

Review-Url: https://codereview.chromium.org/1938113002
Cr-Commit-Position: refs/heads/master@{#391598}

[modify] https://crrev.com/406527c97434a63dea38c3b77024f8dde2765c34/media/gpu/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment